Conversation
The Phoenix onboarding tour and the newly-added-features markdown were both wired up in ways that left users in non-default native projects silently un-onboarded. Two specific gaps: - new-project.js only called guidedTour.startTourIfNeeded() from closeDialogue() (fires when the new-project dialog is opened and then dismissed via openFolder) and from init() when the welcome screen pref was off. On a native app with a non-default project open, _shouldNotShowDialog() returned true and the dialog was never shown, so startTourIfNeeded() was never reached and the tour could not fire on any subsequent boot either. - newly-added-features.init() was called directly from main.js regardless of project context, so the "what's new" markdown could open under a user's current project tabs instead of the welcome project. Move all post-boot orchestration to guided-tour.js, fire it from a single _bootDonePromise.then() in new-project.js, and gate the "newly added features" surfacing on a real higher-version change (detected via semver vs the new userAlreadyDidAction.lastSeenAppVersion). On a higher version we switch to the welcome project first so the markdown lands in the onboarding context. Downgrades are a no-op and leave state untouched so a future re-upgrade to a previously-seen version does not re-fire. PhoenixTour stays a once-per-lifetime overlay tour gated by its own CURRENT_TOUR_VERSION constant.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.