Skip to content

fix(live-preview): toolbar buttons occluded by centre section with long filenames #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 1 commit into from
May 27, 2026
Merged

fix(live-preview): toolbar buttons occluded by centre section with long filenames #2942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src-node/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 22 additions & 1 deletion src/extensionsIntegrated/Phoenix-live-preview/live-preview.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,13 @@
color: rgba(100, 180, 255, 0.8);
}

#live-preview-plugin-toolbar {

Check warning on line 378 in src/extensionsIntegrated/Phoenix-live-preview/live-preview.css

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Duplicate selector "#live-preview-plugin-toolbar", first used at line 11 


See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ5pugbSjH9ez_06_QaA&open=AZ5pugbSjH9ez_06_QaA&pullRequest=2942
display: flex;
align-items: center;
flex-direction: row;
}

.lp-toolbar-left {
width: 20%;
display: flex;
align-items: center;
gap: 6px;
Expand All @@ -385,6 +390,22 @@
flex-shrink: 0;
}

.lp-toolbar-centre {
flex: 1;
min-width: 0;
display: flex;
justify-content: center;
align-items: center;
overflow: hidden;
}

.lp-toolbar-right {
display: flex;
align-items: center;
justify-content: flex-end;
flex-shrink: 0;
}

#reloadLivePreviewButton,
#designModeToggleLivePreviewButton {
width: 28px;
Expand Down
6 changes: 3 additions & 3 deletions src/extensionsIntegrated/Phoenix-live-preview/panel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div id="panel-live-preview">
<div id="live-preview-plugin-toolbar" class="plugin-toolbar" style="display: flex; align-items: center; flex-direction: row;">
<div id="live-preview-plugin-toolbar" class="plugin-toolbar">
<div class="lp-toolbar-left">
<button id="reloadLivePreviewButton" title="{{clickToReload}}" class="btn-alt-quiet toolbar-button">
<i class="fa-solid fa-arrow-rotate-right"></i>
Expand All @@ -16,7 +16,7 @@
</button>
</span>
</div>
<div style="width: fit-content;min-width: 60%;display: flex;justify-content: center; align-items: center;">
<div class="lp-toolbar-centre">
<!-- these are buttons that are always invisible to help central align the panel title-->
<button id="safariButtonBallast" title="{{openInSafari}}" class="btn-alt-quiet toolbar-button live-preview-browser-btn forced-hidden">
<img src="thirdparty/devicon/icons/safari/safari-original.svg" />
Expand Down Expand Up @@ -47,7 +47,7 @@
<img src="thirdparty/devicon/icons/firefox/firefox-original.svg" />
</button>
</div>
<div style="width: 20%;display: flex;align-items: center; justify-content: flex-end">
<div class="lp-toolbar-right">
<button id="livePreviewSettingsBtn" title="{{livePreviewSettings}}"
class="btn-alt-quiet toolbar-button lp-settings-icon"><i class="fa-solid fa-gear"></i></button>
</div>
Expand Down
Loading