Many issues with options types

[pixelzoom]

There are many issues with options types in this repo, including:

• missing type definitions for subclasses
• malformed uses of optionize
• places where combineOptions should be used instead of optionize

It's probably easist if I address them, then assign to @jessegreenberg and @zepumph to review. (I hope that's OK.)

[pixelzoom]

@jessegreenberg and/or @zepumph please review. Let me know if you have any questions, or if you see any problems.

[zepumph]

Thanks for this. There was definitely some slop there that I was glad to sort out. I have two thoughts here.

1. Announcer.announce is kinda a tricky case. We want to be able to pass in options from Utterance.announcerOptions, but when creating an announcer, it isn't parameterized to the Announcer it will announce to (by design). So we don't really have strong typing there. Thus announce methods are a bit strange to begin with, but I think your and my commits help with this.
2. We still seem to be coming to a consensus as a project about when and how to use combineOptions. The cases you had though don't seem correct to me. In each case, I prefer optionize because there are actual defaults that we want to make sure are provided, because they are used later in the function. I think that vast majority of options usages in functions will use Optionize instead of combineOptions, because, though they most likely lack parent options, they will still need the type safety as SelfOptions and ProvidedOptions come together (ensuring defaults are provided).

Please review. I'm happy to discuss further.