Improve settings view navigation and layout responsiveness#2
Merged
Conversation
- Remove max-w-2xl constraint from SettingsContainer to fill available width - Add back button to settings view visible only on mobile (lg:hidden) - Pass onBack callback from BookmarkList to enable navigation back to bookmarks
✅ Deploy Preview for hypermarkk ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the settings view with better navigation controls and improved responsive layout handling. Added a back button for mobile users to return to bookmarks and adjusted the settings container to use full width instead of a fixed max-width constraint.
Key Changes
onBackcallback prop toSettingsViewcomponent and passed it fromBookmarkListto enable returning to the bookmarks viewlgbreakpoint) that displays the chevron icon and "Bookmarks" labelSettingsContainerfrommax-w-2xl mx-autotow-fullfor better full-width utilization on all screen sizesImplementation Details
onBackprop is providedlg:hidden) where navigation is likely handled differently-ml-1 mb-2to align with the settings heading belowtext-muted-foreground,hover:text-foreground) for visual consistency