Prevent tag selection on Ctrl/Cmd+Enter to allow save action#22
Merged
Conversation
When pressing Ctrl+Enter (or Cmd+Enter on Mac) in the tag selection dropdown, the save action should be triggered without selecting the currently highlighted tag. This makes the behavior more intuitive - Ctrl+Enter means "save as-is" regardless of what's highlighted. https://claude.ai/code/session_01XANuHfRC6v45FxosHFmxYT
✅ Deploy Preview for hypermarkk ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the TagInput component to prevent tag selection and creation when Ctrl/Cmd+Enter is pressed, allowing the keyboard shortcut to bubble up for save actions instead.
Changes
ctrlKeyandmetaKeymodifiers before selecting a tag from the dropdownctrlKeyandmetaKeymodifiers before creating a new tag from inputDetails
Previously, pressing Ctrl/Cmd+Enter in the TagInput would trigger tag selection/creation, preventing the common save shortcut from working at the application level. Now, when either modifier key is held, the Enter key event is allowed to propagate up the component tree, enabling parent components to handle the save action while still supporting regular Enter key functionality for tag operations.
https://claude.ai/code/session_01XANuHfRC6v45FxosHFmxYT