Refactor bookmark selection UI with always-visible checkbox#29
Merged
Conversation
- Always render checkbox area for consistent layout alignment - Show faint checkbox on hover that initiates selection mode when clicked - Style checked rows with blue background and filled checkmark - Keep keyboard selection ring visible on top of selected backgrounds - Add spacer to align search bar with bookmark titles https://claude.ai/code/session_01Va8iAR47nsxvRy6LmLofCP
✅ Deploy Preview for hypermarkk ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Use opacity-0/group-hover:opacity-100 to ensure the checkbox is completely hidden until that specific row is hovered, not all rows.
Use opacity and pointer-events instead of conditional rendering for edit/delete buttons so rows don't change height when entering selection mode.
Automatically exit selection mode when the user deselects the last remaining selected bookmark.
The escape key was resetting the sequence but not checking for registered escape handlers. Now it properly calls the escape/esc handler if one exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved the bookmark selection experience by making the checkbox always visible and refactoring the selection state styling. This provides better visual consistency and clearer affordance for users to interact with bookmarks.
Key Changes
SquareandCheckSquareicons with a singleCheckicon for a cleaner implementationbg-primary/15for better visual hierarchyImplementation Details
handleCheckboxClickfunction now intelligently handles both selection mode initiation and togglingshowKeyboardSelection) is calculated separately to ensure it displays with proper visual priorityhttps://claude.ai/code/session_01Va8iAR47nsxvRy6LmLofCP