Performance test improvements #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 97.73% (diff: 100%)@@ master #157 diff @@
==========================================
Files 6 6
Lines 221 221
Methods 0 0
Messages 0 0
Branches 44 44
==========================================
Hits 216 216
Misses 2 2
Partials 3 3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar idea to #138. Still nowhere near perfect, but it's an incremental improvement.
This also creates a separate job in the build matrix specifically for the performance tests. This should make the test suite a little faster, but it will also prevent fluctuations in CI performance from accidentally failing random builds (due to threshold overage). The chance that this could happen is limited to the one job instead of all ~20 jobs.