Skip to content

Conversation

@rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Nov 23, 2015

  • breaks apart tests module into package
  • simplifies test data definitions
  • removes 1s timing delay
  • tests are no longer distributed with the package on pypi

@rpkilby rpkilby mentioned this pull request Nov 23, 2015
@philipn
Copy link
Owner

philipn commented Nov 23, 2015

This looks great, but RE: "tests are no longer distributed with the package on pypi": While most people don't run their dependencies' tests, some people might want to. I noticed that DRF doesn't distribute their tests. Is there a convention here?

@rpkilby
Copy link
Collaborator Author

rpkilby commented Nov 23, 2015

Hm, I think the general consensus is to exclude tests from the distributed package. Basically,

  • Most users don't care about running their dependencies' tests continuously. They rely on code coverage/other metrics, and community reputation/popularity. Essentially, a one time valuation that the code meets their standards.
  • For the users that do want to run the tests, this often requires additional test dependencies and setup anyway, so they would need to add a step to their build process.

@rpkilby
Copy link
Collaborator Author

rpkilby commented Dec 13, 2015

@philipn - Did you have a chance to think about this? After looking at a number of other packages, I'm still of the opinion to not include tests, but it's not a very important issue to me.

philipn added a commit that referenced this pull request Dec 14, 2015
@philipn philipn merged commit 5ef0bf6 into philipn:master Dec 14, 2015
@philipn
Copy link
Owner

philipn commented Dec 14, 2015

Sweet, looks great!

@rpkilby rpkilby deleted the test-restructure branch January 13, 2016 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants