ci: reduce the scope of acceptance test secrets#1137
Merged
Ron (rjaegers) merged 6 commits intomainfrom Feb 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request simplifies secret management in GitHub Actions workflows by removing explicit secret passing and introducing an environment-based approach for acceptance tests. The changes reduce workflow complexity while maintaining security through GitHub's environment protection.
Changes:
- Removed secret definitions and passing for test credentials (
TEST_GITHUB_TOKEN,TEST_GITHUB_USER,TEST_GITHUB_PASSWORD,TEST_GITHUB_TOTP_SECRET) from workflow configurations - Added
environment: acceptance-testingto the acceptance test job to enable environment-level secret access - Streamlined workflow inputs by removing unused secret requirements
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/wc-build-push-test.yml |
Removed secret input definitions and passing to acceptance test workflow |
.github/workflows/wc-acceptance-test.yml |
Removed secret inputs and added environment property to test job |
.github/workflows/continuous-integration.yml |
Removed secret passing to build-push-test workflow |
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 21 | 0 | 0 | 0.51s | |
| ✅ DOCKERFILE | hadolint | 3 | 0 | 0 | 0.69s | |
| ✅ GHERKIN | gherkin-lint | 6 | 0 | 0 | 2.53s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.46s | |
| ✅ JSON | prettier | 21 | 4 | 0 | 0 | 0.46s |
| ✅ JSON | v8r | 21 | 0 | 0 | 7.09s | |
| ✅ MARKDOWN | markdownlint | 12 | 0 | 0 | 0 | 0.96s |
| ✅ MARKDOWN | markdown-table-formatter | 12 | 0 | 0 | 0 | 0.35s |
| ✅ REPOSITORY | checkov | yes | no | no | 17.38s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.53s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 29.8s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 0.89s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.83s | |
| ✅ REPOSITORY | trivy | yes | no | no | 7.74s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.23s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.19s | |
| lychee | 81 | 1 | 0 | 43.46s | ||
| ✅ YAML | prettier | 29 | 0 | 0 | 0 | 1.29s |
| ✅ YAML | v8r | 29 | 0 | 0 | 7.21s | |
| ✅ YAML | yamllint | 29 | 0 | 0 | 0.87s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....123
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Ron (rjaegers)
had a problem deploying
to
acceptance-testing
GitHub Actions
Failure
Contributor
Ron (rjaegers)
had a problem deploying
to
acceptance-testing
GitHub Actions
Failure
Ron (rjaegers)
temporarily deployed
to
acceptance-testing
GitHub Actions
Inactive
Ron (rjaegers)
had a problem deploying
to
acceptance-testing
GitHub Actions
Failure
Ron (rjaegers)
had a problem deploying
to
acceptance-testing
GitHub Actions
Error
|
Ron (rjaegers)
had a problem deploying
to
acceptance-testing
GitHub Actions
Failure
Ron (rjaegers)
had a problem deploying
to
acceptance-testing
GitHub Actions
Error
Ron (rjaegers)
temporarily deployed
to
acceptance-testing
GitHub Actions
Inactive
André Jordan (andjordan)
approved these changes
Feb 25, 2026
Contributor
Pull Request Report (#1137)Static measures
Time related measures
Status check related measures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This pull request introduces improvements to the CI workflow configuration, primarily focusing on conditional test execution and environment setup for acceptance testing. The changes ensure that tests are run more selectively and in a properly defined environment.
Conditional test execution and workflow configuration:
acceptance-test-pathlogic in.github/workflows/continuous-integration.ymlto skip acceptance tests for thecppflavor when triggered by Dependabot, improving efficiency and avoiding unnecessary test runs.test-devcontainer-fileassignment to dynamically select the correct devcontainer configuration based on the test flavor, reducing hardcoded logic and improving maintainability.Environment setup for acceptance testing:
environment: acceptance-testingdeclaration to the acceptance test job in.github/workflows/wc-acceptance-test.yml, ensuring tests run in a consistent and isolated environment.✔️ Checklist