Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Jun 23, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This PR enables the "pedantic" persona of the zizmor linter and fixes (part of) the findings.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings June 23, 2025 11:56
@rjaegers rjaegers requested a review from a team as a code owner June 23, 2025 11:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the “pedantic” persona for the Zizmor linting action in the CI pipeline.

  • Adds with: persona: pedantic inputs to the Zizmor Action step.
  • Updates the linting-formatting workflow configuration.
Comments suppressed due to low confidence (1)

.github/workflows/linting-formatting.yml:32

  • The with: block must be indented under the same step as - uses: zizmorcore/zizmor-action…. In YAML, it should look like:
        with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edge to ghcr.io/philips-software/amp-devcontainer-rust:pr-840

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend
linux/amd64 489.22M 489.22M 0.00 (+0.00%) 🔄
linux/arm64 441.18M 441.18M 0.00 (+0.00%) 🔄

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 18 0 0 0.49s
✅ DOCKERFILE hadolint 2 0 0 0.86s
✅ GHERKIN gherkin-lint 2 0 0 0.92s
✅ JSON npm-package-json-lint yes no no 0.37s
✅ JSON prettier 16 1 0 0 0.41s
✅ JSON v8r 16 0 0 7.35s
✅ MARKDOWN markdownlint 9 0 0 0 0.89s
✅ MARKDOWN markdown-table-formatter 9 0 0 0 0.26s
✅ REPOSITORY checkov yes no no 15.35s
✅ REPOSITORY gitleaks yes no no 0.39s
✅ REPOSITORY git_diff yes no no 0.01s
⚠️ REPOSITORY grype yes no 1 23.11s
✅ REPOSITORY secretlint yes no no 0.94s
✅ REPOSITORY syft yes no no 1.92s
✅ REPOSITORY trivy yes no no 5.31s
✅ REPOSITORY trivy-sbom yes no no 0.23s
✅ REPOSITORY trufflehog yes no no 2.99s
✅ SPELL lychee 63 0 0 11.41s
✅ YAML prettier 24 0 0 0 0.87s
✅ YAML v8r 24 0 0 5.65s
✅ YAML yamllint 24 0 0 0.67s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

📦 Container Size Analysis

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edge to ghcr.io/philips-software/amp-devcontainer-cpp:pr-840

📈 Size Comparison Table

OS/Platform Previous Size Current Size Change Trend
linux/amd64 657.00M 657.00M 0.00 (+0.00%) 🔄
linux/arm64 639.71M 639.71M 0.00 (+0.00%) 🔄

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

Test Results

 4 files  ±0   4 suites  ±0   2m 26s ⏱️ +3s
30 tests ±0  30 ✅ ±0  0 💤 ±0  0 ❌ ±0 
64 runs  ±0  64 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1e9da2a. ± Comparison against base commit fa0ce10.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

@rjaegers rjaegers merged commit 775af7d into main Jul 14, 2025
34 checks passed
@rjaegers rjaegers deleted the feature/enable-zizmor-pedantic-mode branch July 14, 2025 07:13
@github-actions
Copy link
Contributor

Pull Request Report (#840)

Static measures

Description Value
Number of added lines 23
Number of deleted lines 13
Number of changed files 5
Number of commits 7
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 20.8 Days
Time that was spend on the branch before the PR was created 13 Sec
Time that was spend on the branch before the PR was merged 20.8 Days
Time to merge after last review 20 Days

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 32.8 Min
Total time spend in last status check run on PR 12.8 Min

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants