Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Oct 22, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This pull request updates the development container configuration to use Clang version 19 and related tools, replacing the previous version 18. This ensures the environment is aligned with Clang toolchain 19 and dependencies.

Toolchain version upgrades:

  • Updated the CLANG_VERSION argument in .devcontainer/cpp/Dockerfile from 18 to 19, and INCLUDE_WHAT_YOU_USE_VERSION from 0.22 to 0.23.
  • Replaced all Clang 18 packages in .devcontainer/cpp/apt-requirements-clang.json with their Clang 19 equivalents, including clang, clangd, clang-format, clang-tidy, clang-tools, libclang-rt-dev, lld, llvm, and mull. Package versions were also updated accordingly.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings October 22, 2025 12:38
@rjaegers rjaegers requested a review from a team as a code owner October 22, 2025 12:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the C++ development container from Clang/LLVM 18 to Clang/LLVM 19, including all associated tools and the mutation testing tool Mull.

Key changes:

  • Updates Clang/LLVM version from 18 to 19 across all toolchain components
  • Updates Mull mutation testing tool from version 0.26.1 to 0.27.0
  • Updates package version strings to the latest 19.1.7 build

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.devcontainer/cpp/apt-requirements-clang.json Updates all Clang/LLVM 19 package versions and Mull to 0.27.0
.devcontainer/cpp/Dockerfile Updates CLANG_VERSION build argument from 18 to 19

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

Test Results

 5 files  ±0   5 suites  ±0   5m 55s ⏱️ + 2m 12s
31 tests ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 
65 runs  ±0  65 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 98d9849. ± Comparison against base commit 2a3ac81.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 21 0 0 0.59s
✅ DOCKERFILE hadolint 2 0 0 0.68s
✅ GHERKIN gherkin-lint 6 0 0 2.32s
✅ JSON npm-package-json-lint yes no no 0.34s
✅ JSON prettier 15 2 0 0 0.43s
✅ JSON v8r 15 0 0 14.42s
✅ MARKDOWN markdownlint 11 0 0 0 0.93s
✅ MARKDOWN markdown-table-formatter 11 0 0 0 0.22s
✅ REPOSITORY gitleaks yes no no 0.68s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 29.93s
✅ REPOSITORY secretlint yes no no 1.01s
✅ REPOSITORY syft yes no no 1.92s
✅ REPOSITORY trivy yes no no 7.27s
✅ REPOSITORY trivy-sbom yes no no 0.25s
✅ REPOSITORY trufflehog yes no no 3.46s
✅ SPELL lychee 72 0 0 21.54s
✅ YAML prettier 27 0 0 0 0.86s
✅ YAML v8r 27 0 0 11.08s
✅ YAML yamllint 27 0 0 0.83s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.1.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@rjaegers rjaegers marked this pull request as draft October 23, 2025 08:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-988

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 536.92 MB 536.92 MB +249 B (+0%) 🔼
linux/arm64 493.6 MB 493.6 MB 42 B (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-988

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 693.65 MB 682.58 MB 11.06 MB (-1.6%) 🔽
linux/arm64 676.93 MB 664.93 MB 12 MB (-1.77%) 🔽

@rjaegers rjaegers marked this pull request as ready for review October 27, 2025 08:58
Copilot AI review requested due to automatic review settings October 27, 2025 08:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
@sonarqubecloud
Copy link

@rjaegers rjaegers added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit db0c8b6 Oct 27, 2025
34 checks passed
@rjaegers rjaegers deleted the feature/update-to-clang-llvm-19 branch October 27, 2025 13:57
@github-actions
Copy link
Contributor

Pull Request Report (#988)

Static measures

Description Value
Number of added lines 11
Number of deleted lines 11
Number of changed files 2
Number of commits 5
Number of reviews 3
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 2
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 5.1 Days
Time that was spend on the branch before the PR was created 2.8 Min
Time that was spend on the branch before the PR was merged 5.1 Days
Time to merge after last review 4.2 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 46.4 Min
Total time spend in last status check run on PR 18.7 Min

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants