fix: redact stdio command args in info#244
Open
haosenwang1018 wants to merge 1 commit intophilschmid:mainfrom
Open
fix: redact stdio command args in info#244haosenwang1018 wants to merge 1 commit intophilschmid:mainfrom
haosenwang1018 wants to merge 1 commit intophilschmid:mainfrom
Conversation
Signed-off-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp-cli infooutputProblem
Issue #217 reports that
mcp-cli infocan reveal secret-bearing command details. The existinginfooutput still printed the entire stdio command line, including raw args.Fix
formatServerDetails()now renders stdio commands as<executable> (<N> hidden arguments)instead of echoing the full arg list. This preserves useful context without leaking flags, paths, or tokens embedded in args.Fixes #217
Validation
bun test tests/output.test.tsnpx tsc --noEmitnpx @biomejs/biome check src/output.ts tests/output.test.tsgit diff --check