fix: flush large piped tool output#246
Open
haosenwang1018 wants to merge 1 commit intophilschmid:mainfrom
Open
fix: flush large piped tool output#246haosenwang1018 wants to merge 1 commit intophilschmid:mainfrom
haosenwang1018 wants to merge 1 commit intophilschmid:mainfrom
Conversation
Signed-off-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.log()incalloutput with an explicit stdout writerdrainwhen stdout backpressure is appliedProblem
Issue #23 reports that large tool results are truncated at 65536 bytes when
mcp-cli call ...is piped to another process. This points to the output path not respecting pipe backpressure.Fix
The
callcommand now writes formatted tool output throughprocess.stdout.write()and awaits thedrainevent when needed, instead of relying onconsole.log(). That keeps the same output shape while ensuring large responses are fully flushed through piped stdout.Fixes #23
Validation
git diff --checknpx tsc --noEmitbun test tests/config.test.tsbun test tests/output.test.tsnpx @biomejs/biome check src/commands/call.ts