Merged
Conversation
Closed
philsmt
force-pushed
the
fix_device_package
branch
from
941fb57 to
a623686
Compare
… module, but add all public symbols
philsmt
force-pushed
the
fix_device_package
branch
from
a623686 to
22585fc
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1 to enable support for spawn method in
multiprocessing, but fixes new issues introduced by moving thedevicesmodule tometro.services. The module is no longer introduced as a symbol into themetronamespace, but only its (mostly) public symbols. This will require some small changes in metro-age as well.Also fixes a minor PyQt-dependent bug in
GenericDevice.__ge__by replacing the magic method with a proper classmethod.