Prevents Floki.Finder.find/2 from crashing#605
Closed
mellelieuwes wants to merge 1 commit intophilss:mainfrom
Closed
Prevents Floki.Finder.find/2 from crashing#605mellelieuwes wants to merge 1 commit intophilss:mainfrom
mellelieuwes wants to merge 1 commit intophilss:mainfrom
Conversation
Owner
|
Makes sense to me. What do you think, @ypconstante ? |
Owner
|
BTW, thank you for the report and the fix, @mellelieuwes ! <2 |
Contributor
|
Since the function is recursive, this will probably cause us to use the expensive traversal in some cases in which we could use the fast one. I think we should handle this in the |
philss
added a commit
that referenced
this pull request
Jun 15, 2025
philss
added a commit
that referenced
this pull request
Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #604