Optimize Finder.get_descendant_ids/2 memory usage and speed#660
Merged
philss merged 2 commits intophilss:mainfrom Mar 16, 2026
Merged
Optimize Finder.get_descendant_ids/2 memory usage and speed#660philss merged 2 commits intophilss:mainfrom
philss merged 2 commits intophilss:mainfrom
Conversation
Replaced ++ and Enum.flat_map with an optimal tail-recursive DFS approach that preserves the correct document traversal order while massively reducing memory usage and increasing execution speed for descendant selectors. Also added a test to explicitly guard against regressions in the descendant matching traversal order.
Owner
|
🚀 🚀 🚀 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizes the traversal of descendant nodes in
Floki.Finderby rewritingget_descendant_ids/2to use an optimal tail-recursive Depth-First Search (DFS) approach.Also included is a new test in
test/floki_test.exsspecifically designed to guard against future regressions in descendant match traversal order.