Optimize multiple selectors deduping#667
Merged
Merged
Conversation
Use `Enum.uniq_by/2` with the `node_id` integer instead of relying on `Enum.uniq/1`'s deep structural equality over massive `HTMLNode` structs. Moving the de-duplication before the sort also results in less elements to be sorted, reducing the list that goes into the O(N log N) sort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Enum.uniq_by/2with thenode_idinteger instead of relying onEnum.uniq/1's deep structural equality over largeHTMLNodestructs.
Moving the de-duplication before the sort results in less elements
to be sorted, reducing the list that goes into the sort.
It's only 1-3% faster but it's also a simplification.