Simplify HTMLTree.build/1 by avoiding redundant build_tree calls#683
Merged
philss merged 1 commit intophilss:mainfrom Apr 15, 2026
Merged
Simplify HTMLTree.build/1 by avoiding redundant build_tree calls#683philss merged 1 commit intophilss:mainfrom
philss merged 1 commit intophilss:mainfrom
Conversation
Text and comment nodes are leaf nodes and don't need the recursive build_tree function. This change simplifies the code and provides a small speedup during tree construction for these node types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text and comment nodes are leaf nodes and therefore don't need the recursive
build_tree function. This change simplifies the code and provides
a small speedup during tree construction for these node types.