fix: support non-string value types in MudBlazor select renderer#87
Merged
fix: support non-string value types in MudBlazor select renderer#87
Conversation
The select field renderer in FormCraftComponent hardcoded MudSelect<string> and MudSelectItem<string>, causing all option values to be converted to strings via ToString(). This meant non-string value types (int, enum, etc.) always returned their default value (e.g., 0 for int) when selected. The fix makes RenderSelectField and RenderSelectOptions generic on the actual property type by using reflection to invoke a generic helper method (RenderSelectFieldGeneric<TValue>) with the correct type parameter derived from the model property. Also adds type conversion safety in UpdateFieldValue. Fixes #61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MudSelectandMudSelectItemcomponents being hardcoded tostringtype parameter, causing non-string select values (e.g.,int,enum) to always return their default value (0 for int)RenderSelectFieldandRenderSelectOptionsgeneric on the actual model property type using reflection-based generic method dispatchUpdateFieldValuefor edge casesChanges
FormCraft.ForMudBlazor/Features/FormContainer/FormCraftComponent.razor.cs: ReplacedRenderSelectFieldwith a reflection-based dispatcher that callsRenderSelectFieldGeneric<TValue>using the actual property type. MadeRenderSelectOptions<TValue>generic soMudSelectItem<TValue>matches the real value type. AddedConvert.ChangeTypefallback inUpdateFieldValue.FormCraft.UnitTests/Extensions/FieldBuilderExtensionsTests.cs: Added two tests verifying thatWithOptionscorrectly storesSelectOption<int>with preserved int value types.Test plan
WithOptions_Should_Set_Int_Options_Attributeverifies int-typed options are stored correctlyWithOptions_Should_Preserve_Int_Value_Typesverifies option values remainint, notstringFixes #61