stdio: implement flockfile, ftrylockfile, funlockfile#477
Open
julianuziemblo wants to merge 2 commits into
Open
stdio: implement flockfile, ftrylockfile, funlockfile#477julianuziemblo wants to merge 2 commits into
julianuziemblo wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements recursive locking for stdio streams by introducing the ftrylockfile function and updating flockfile and funlockfile to utilize mutex operations. It also updates fopen, fdopen, popen, and internal file initialization to use mutexCreateWithAttr with a recursive lock attribute. The review feedback correctly identifies that the return values of mutexCreateWithAttr in fopen and fdopen are not checked, which could lead to undefined behavior if a lock fails to initialize. Suggestions were provided to include proper error handling and resource cleanup in these functions.
YT: RTOS-1334
YT: RTOS-1334
julianuziemblo
force-pushed
the
julianuziemblo/RTOS-1334
branch
from
0531361 to
e3f29f7
Compare
Unit Test Results10 618 tests 9 948 ✅ 52m 0s ⏱️ Results for commit e3f29f7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YT: RTOS-1334
Description
Motivation and Context
Types of changes
How Has This Been Tested?
ia32-generic-qemuChecklist:
Special treatment