Draft
Conversation
Unit Test Results7 437 tests +153 6 707 ✅ +138 38m 58s ⏱️ + 3m 8s For more details on these failures, see this check. Results for commit e69015e. ± Comparison against base commit d8f54fa. ♻️ This comment has been updated with latest results. |
damianloew
requested changes
Nov 20, 2023
Contributor
damianloew
left a comment
damianloew
left a comment
There was a problem hiding this comment.
Haven't checked ftell in detail yet.
KArkadiusz
force-pushed
the
KArkadiusz/stdio_indicator_test
branch
3 times, most recently
from
61e0e35 to
2cf76e1
Compare
KArkadiusz
force-pushed
the
KArkadiusz/stdio_indicator_test
branch
from
2cf76e1 to
67a9a25
Compare
damianloew
requested changes
Nov 30, 2023
damianloew
reviewed
Nov 30, 2023
mateusz-bloch
requested changes
Apr 4, 2024
KArkadiusz
force-pushed
the
KArkadiusz/stdio_indicator_test
branch
from
67a9a25 to
9c99d54
Compare
mateusz-bloch
requested changes
Apr 10, 2024
KArkadiusz
force-pushed
the
KArkadiusz/stdio_indicator_test
branch
from
9c99d54 to
e69015e
Compare
KArkadiusz
force-pushed
the
KArkadiusz/stdio_indicator_test
branch
from
e69015e to
3b1099f
Compare
Comment on lines
+220
to
+221
| char c; | ||
| while ((c = fgetc(f)) != -1) { |
Member
There was a problem hiding this comment.
On our ARM architectures targets char is from 0 to 255,, maybe use signed char or int for c
JIRA: CI-366
lukkrusz
force-pushed
the
KArkadiusz/stdio_indicator_test
branch
from
3b1099f to
ecdeffa
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment