use left join in getLog() finders when no ecrfId is provided

[rkrenn]

this is a regression from 7fd549a "ecrf<->visits many-to-many - adjust DAOs"
that comes into effect in the uncommon case of using eCRFs without any visit.

Summary by CodeRabbit

• Bug Fixes
  • Fixed missing eCRF field values and status entries that were not linked to a visit, so they now appear in logs, history, and related views.
  • Improved query behavior when filtering by visit to consistently include applicable records without an associated visit, ensuring complete audit trails and accurate counts.

[rkrenn]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Switches the Visit association join type to LEFT JOIN in criteria-building paths within ECRFFieldStatusEntryDaoImpl and ECRFFieldValueDaoImpl, affecting detached criteria generation and specific log-query fast paths. No public API or signatures changed.

Changes

Cohort / File(s)	Summary
ECRFFieldStatusEntry: LEFT JOIN for Visit in criteria core/src/main/java/org/phoenixctms/ctsms/domain/ECRFFieldStatusEntryDaoImpl.java	Replaced implicit/default join with LEFT_JOIN for "visit" in: detached criteria max-id builder and two handleGetLog fast-paths.
ECRFFieldValue: LEFT JOIN for Visit in criteria core/src/main/java/org/phoenixctms/ctsms/domain/ECRFFieldValueDaoImpl.java	Replaced implicit/default join with LEFT_JOIN for "visit" in: detached criteria builder and two handleGetLog branches when visitId is null.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant DAO as DAO (ECRF*DaoImpl)
  participant HC as Hibernate Criteria
  participant DB as Database

  DAO->>HC: build criteria
  note right of HC: Join Visit using LEFT JOIN (changed)
  HC->>HC: add visit filters<br/>- visit.id is null OR<br/>- visit.id = :visitId
  DAO->>HC: finalize (projections/subqueries)
  HC->>DB: execute query
  DB-->>HC: result set (includes rows without Visit)
  HC-->>DAO: return results

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudge the joins from right to left,
So visits lost aren’t left bereft.
Logs now hum a broader tune,
Catching ghosts beneath the moon.
With twitching ears and tidy code,
This rabbit smooths the query road. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between de21432 and 677e725.

📒 Files selected for processing (2)

• core/src/main/java/org/phoenixctms/ctsms/domain/ECRFFieldStatusEntryDaoImpl.java (3 hunks)
• core/src/main/java/org/phoenixctms/ctsms/domain/ECRFFieldValueDaoImpl.java (3 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ecrf_issues_no_visit

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.