Conversation
rkrenn
requested review from
01hasenberger,
SigridDeller,
fladi and
ultchagen
Closed
Collaborator
Author
|
@CodeRabbit review |
Contributor
✅ Actions performedReview triggered.
|
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughUpdates CI scripts and Selenium setup; introduces Bulk Processor setup. Refactors XLS import/export with new base classes and JXL dependency, changing packages and interfaces. Adjusts CSV/XLS processors to use ProcessorJobOutput and public postProcess. Enhances tests, adds new trial ECRF Selenium test and FTP uploads. Adds settings and UI link for validation reports. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller as Caller
participant Exporter as XlsExporter (extends Base)
participant Base as XlsExporterBase
participant Writer as RowWriter
participant JXL as JXL Workbook
Caller->>Exporter: setJobOutput(JobOutput)
Caller->>Exporter: printRows(context, writer)
Exporter->>Base: printRows(context, writer)
Base->>Writer: setContext, init()
alt file output
Base->>JXL: create Workbook (File)
else memory output
Base->>JXL: create Workbook (ByteArray)
end
Base->>Writer: printHeaderRow()
loop rows
Base->>Writer: printRows()
end
Base->>JXL: write() and close()
alt memory output
Base->>Exporter: addEmailXlsAttachment(data)
Exporter-->>Caller: attachment via JobOutput
end
Base-->>Caller: return row count
sequenceDiagram
autonumber
participant Test as SeleniumTestBase
participant Sys as System Props
participant FTP as FTP Server
Test->>Test: generate report files (PDF/ZIP)
Test->>Sys: read ftp.host, ftp.username, ftp.password, ftp.path
Test->>FTP: connect/login
loop each report file
Test->>FTP: storeFile(remotePath, file)
end
Test->>FTP: logout/disconnect
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60–90 minutes Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.38.6)core/src/main/java/org/phoenixctms/ctsms/service/trial/TrialServiceImpl.java📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (66)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the commit for our 2nd End-To-End testsuite based on chrome webdriver/selenium server.
it is to be executed automatically by the GitHub java CI (see "Actions" https://github.com/phoenixctms/ctsms/actions).
the use case covered is the "eCRF Date Entry and Export", as raised by AGES Inspektion KPAM 398.
Test outline:
An example of the generated test report PDF is attached below. It represent the documentation mandatory for software validation in regulated environments.
Trial Tests.pdf
Feel free to contact us if you need these test report documents as well.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Tests
Chores