Skip to content

left-oriented tabviews#283

Merged
rkrenn merged 3 commits intomasterfrom
lefttabview
Feb 27, 2024
Merged

left-oriented tabviews#283
rkrenn merged 3 commits intomasterfrom
lefttabview

Conversation

@rkrenn
Copy link
Copy Markdown
Collaborator

@rkrenn rkrenn commented Feb 27, 2024

Summary by CodeRabbit

  • New Features
    • Tabs now switch orientation automatically: when more than five tabs are visible, layout changes to vertical (left) for better navigation across Course, Input Field, Inventory, Mass Mail, Proband, Staff, Trial, and User pages.
  • Style
    • Added styling for left-oriented tabs (nav width, panel layout, borders, padding) to ensure consistent appearance.
  • Chores
    • Updated PostgreSQL JDBC driver to 42.3.9.

@rkrenn rkrenn merged commit 15acd68 into master Feb 27, 2024
@rkrenn
Copy link
Copy Markdown
Collaborator Author

rkrenn commented Aug 19, 2025

@CodeRabbit review full

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 19, 2025

@rkrenn I'll conduct a full review of the PR changes related to left-oriented tabviews.

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a dynamic orientation attribute to multiple PrimeFaces p:tabView components to switch between left and top based on visible tab count, introduces corresponding CSS for left-oriented tabs, and bumps the PostgreSQL JDBC driver from 42.3.7 to 42.3.9 in pom.xml.

Changes

Cohort / File(s) Summary
Dependency bump
pom.xml
Update org.postgresql:postgresql from 42.3.7 to 42.3.9.
TabView dynamic orientation
web/src/main/webapp/course/course.xhtml, .../inputfield/inputField.xhtml, .../inventory/inventory.xhtml, .../massmail/massMail.xhtml, .../proband/proband.xhtml, .../staff/staff.xhtml, .../trial/trial.xhtml, .../user/user.xhtml
Add p:tabView orientation with EL: left when corresponding VisibleTabSet.size() > 5, else top. No other behavior changed.
Left tabs styling
web/src/main/webapp/resources/css/default.css
Add CSS rules for .ui-tabs-left navigation, panels, panel padding, and left-nav item borders.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor User
    participant Browser
    participant JSF as JSF View
    participant TabView as p:TabView
    participant SessionBean as sessionScopeBean
    participant Renderer as PrimeFaces Renderer
    Note over User,Browser: Page load or view render

    User->>Browser: Navigate to page
    Browser->>JSF: HTTP request
    JSF->>TabView: Build component tree
    TabView->>SessionBean: Evaluate VisibleTabSet.size()
    SessionBean-->>TabView: size (n)
    TabView->>Renderer: orientation = (n>5 ? left : top)
    Renderer-->>Browser: HTML/CSS for tabs
    Note over Browser: CSS .ui-tabs-left styles applied when left
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A nibble of code, a hop to the left,
Tabs turn vertical when the herd is deft.
Eight views align as carrots in rows,
CSS whispers how the layout goes.
Postgres bumps with a quiet cheer—
Thump-thump! says the rabbit: “Ship it here.” 🥕

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4d47ad0 and 0e5b35c.

📒 Files selected for processing (10)
  • pom.xml (1 hunks)
  • web/src/main/webapp/course/course.xhtml (1 hunks)
  • web/src/main/webapp/inputfield/inputField.xhtml (1 hunks)
  • web/src/main/webapp/inventory/inventory.xhtml (1 hunks)
  • web/src/main/webapp/massmail/massMail.xhtml (1 hunks)
  • web/src/main/webapp/proband/proband.xhtml (1 hunks)
  • web/src/main/webapp/resources/css/default.css (1 hunks)
  • web/src/main/webapp/staff/staff.xhtml (1 hunks)
  • web/src/main/webapp/trial/trial.xhtml (1 hunks)
  • web/src/main/webapp/user/user.xhtml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lefttabview

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant