password policy defaults to generate passwords that are easier to read

[rkrenn]

Summary by CodeRabbit

• New Features
  • Updated password requirements: reduced minimum required symbols and stricter maximums for several character types. Password validation, generation, and displayed requirement messages now reflect these rules.
• Style
  • Minor whitespace cleanup in the proband address form with no functional impact.

[rkrenn]

@CodeRabbit review full

[coderabbitai]

@rkrenn I'll conduct a full review of all the changes in this PR.

✅ Actions performed

Full review triggered.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces a package-private flag in PasswordPolicy to optionally bypass per-class max-occurrence checks. Adjusts CharacterSet.add validation accordingly. Updates password generation, validation, and requirements to respect the flag. Configuration properties set several max counts to 0 and reduce min symbols. One XHTML file has whitespace cleanup.

Changes

Cohort / File(s)	Summary
Security policy logic core/src/main/java/org/phoenixctms/ctsms/security/PasswordPolicy.java, core/src/main/java/org/phoenixctms/ctsms/security/CharacterSet.java	Added IGNORE_MAX_OCCURRENCENS flag; gated max-occurrence checks in validation, generation, and requirements; adjusted CharacterSet.add condition; minor iterator reuse in getRandomString.
Password policy configuration core/src/main/resources/ctsms-settings.properties	Reduced password_min_symbols to 0; set several per-class max values to 0 (global and department); resulting constraints disable multiple classes.
Web UI formatting web/src/main/webapp/META-INF/includes/proband/probandAddress.xhtml	Removed extra blank lines; no functional changes.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant PasswordPolicy
  participant CharacterSet

  Client->>PasswordPolicy: checkStrength(password, policy)
  PasswordPolicy->>PasswordPolicy: if (!IGNORE_MAX_OCCURRENCENS) enforce max per class
  PasswordPolicy->>PasswordPolicy: always enforce min per class and length
  PasswordPolicy-->>Client: result/exception

Loading

sequenceDiagram
  participant Client
  participant PasswordPolicy
  participant CharacterSet

  Client->>PasswordPolicy: getRandomString(policy)
  loop build password
    PasswordPolicy->>CharacterSet: select next class (iterator)
    PasswordPolicy->>PasswordPolicy: if (!IGNORE_MAX_OCCURRENCENS) check max per class
    PasswordPolicy->>PasswordPolicy: ensure mins until satisfied
  end
  PasswordPolicy-->>Client: password

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

I twitch my ears at toggled gates,
A flag that bends the password fates.
Maxes hush when set to true,
While configs zero out the queue.
Hop, hop—constraints re-align,
Carrots count? That’s by design.
Secure burrow, sleek and fine. 🥕✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 24167e3 and 190ed34.

📒 Files selected for processing (4)

• core/src/main/java/org/phoenixctms/ctsms/security/CharacterSet.java (1 hunks)
• core/src/main/java/org/phoenixctms/ctsms/security/PasswordPolicy.java (4 hunks)
• core/src/main/resources/ctsms-settings.properties (2 hunks)
• web/src/main/webapp/META-INF/includes/proband/probandAddress.xhtml (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ignore_passwd_max_occurrences

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.