internal visit schedule items, collision toggle switches, form scripting lib files support#335
Merged
internal visit schedule items, collision toggle switches, form scripting lib files support#335
Conversation
+ internal visit schedule description field + getProbandListEntryTagCount startTags parameter
Collaborator
Author
|
@CodeRabbit full review |
Contributor
✅ Actions performedFull review triggered. |
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughDatabase adds internal (boolean) and description (text) to visit_schedule_item with migration to 010801080. DAO/service methods gain an optional internal filter and broadened search criteria. UI adds “Conflicts” toggles across lists, new visit-schedule columns/inputs, and label/setting keys. FieldCalculation gains secure file-backed script loading. Misc dependency bump and README cleanup. Changes
Sequence Diagram(s)sequenceDiagram
participant UI
participant Service as Trial/Proband/Staff Service
participant DAO as VisitScheduleItemDao
participant DB
UI->>Service: find items (trialId, groupId, probandId, internal?, interval,…)
Service->>DAO: query(..., internal?, ...)
DAO->>DB: SELECT ... WHERE ... AND (internal = ? if provided)
DB-->>DAO: rows
DAO-->>Service: items
Service-->>UI: items
sequenceDiagram
participant JS as fieldCalculation.js
participant Bridge as FieldCalculation (Java)
participant FileDao
participant Store as DB/FileStore
JS->>Bridge: getScript(resource, fileId)
alt encrypted/not public
Bridge-->>JS: throw error
else ok
Bridge->>FileDao: load(fileId)
FileDao->>Store: fetch bytes
Store-->>FileDao: bytes
FileDao-->>Bridge: bytes
Bridge-->>JS: UTF-8 string
JS->>JS: cache/eval utilities
end
sequenceDiagram
participant User
participant XHTML as DataTable (XHTML)
participant Bean as *Bean.showCollisions
participant Include as listCollisionIcon.xhtml
User->>XHTML: Toggle collisions checkbox
XHTML->>Bean: setShowCollisions(value), handleShowCollisionsChange()
Bean->>Bean: clear collision caches
XHTML->>Include: rendered = Bean.showCollisions, value = count
Include-->>XHTML: icon rendered only if rendered && value!=null
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60–90 minutes Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.38.6)core/src/main/java/org/phoenixctms/ctsms/service/proband/ProbandServiceImpl.javacore/src/main/java/org/phoenixctms/ctsms/service/staff/StaffServiceImpl.javacore/src/main/java/org/phoenixctms/ctsms/service/trial/TrialServiceImpl.java
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This was referenced Aug 21, 2025
Closed
This was referenced Aug 28, 2025
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closing #332
closing #333
closing #334
Summary by CodeRabbit
New Features
Improvements
Documentation
Chores