fix textareas not accepting enter on pages with autocomplete fields w. strict mode#337
Merged
fix textareas not accepting enter on pages with autocomplete fields w. strict mode#337
Conversation
Collaborator
Author
|
@CodeRabbit full review |
Contributor
✅ Actions performedFull review triggered. |
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughAdds a keypress handler to several JSF forms, refines the base template’s Enter-key logic to allow Enter in textareas, and introduces a validation check in a PrimeFaces override to throw an error when a nested array is passed to SelectManyCheckbox.setValue. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant F as JSF h:form
participant H as autoCompleteForceSelectionPreventFormSubmission
U->>F: Keypress (Enter/other)
F->>H: Invoke handler
alt Enter in textarea
H-->>F: allow (true)
F-->>U: Insert newline / continue typing
else Enter in non-textarea
H-->>F: prevent (false)
F-->>U: Block form submission
end
sequenceDiagram
participant App as App Code
participant PF as PrimeFaces SelectManyCheckbox.setValue
App->>PF: setValue(value[])
loop for each element
alt element is Array
PF-->>App: throw Error("value element is an array")
else element is scalar
PF-->>App: proceed with matching/checking
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (7)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit