fix datatables jumping to page 1 on refresh

[rkrenn]

Summary by CodeRabbit

• Bug Fixes
  • Pagination in data tables no longer jumps back to the first page unless filters actually change, reducing disruption during browsing.
  • Improved filter change detection prevents unnecessary updates, leading to smoother interactions and more consistent paging behavior across lazy-loaded views.
  • Repeated searches or refreshes without modifying filters now preserve the current page, enhancing usability and minimizing unexpected navigation.

[rkrenn]

@CodeRabbit full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Conditional page reset added when filters change: SessionScopeBean.setFilterMap now returns whether the filter map changed, and DataTable resets the page to 0 only when an update occurs for data-model paging; non-data-model paging still resets first to 0. Method signature updated to return boolean.

Changes

Cohort / File(s)	Summary of changes
DataTable conditional paging reset web/src/main/java/org/phoenixctms/ctsms/web/component/datatable/DataTable.java	Stores boolean result from SessionScopeBean.setFilterMap; resets LazyDataModel page to 0 only if filters changed; non-data-model path still sets first to 0; no other logic altered.
Session filter change detection & API update web/src/main/java/org/phoenixctms/ctsms/web/model/SessionScopeBean.java	setFilterMap now returns boolean; compares existing and new filter maps; updates stored map only on difference and returns true, else false; signature changed from void to boolean.

Sequence Diagram(s)

sequenceDiagram
  participant UI as DataTable
  participant Sess as SessionScopeBean
  participant Model as LazyDataModel

  UI->>Sess: setFilterMap(clientId, filters)
  Sess-->>UI: updated (boolean)

  alt usePageFromDataModel() and updated == true
    UI->>Model: setPage(0)
  else usePageFromDataModel() and updated == false
    UI-->>UI: keep current page
  end

  opt !usePageFromDataModel()
    UI-->>UI: setFirst(0)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I twitch my ears at filters new,
A hop if changed, else no redo.
Pages rest when maps shift shape,
If not, I nibble, no escape.
Carrots counted, state held tight—
One small hop makes paging right. 🥕✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1a9165e and 2c68849.

📒 Files selected for processing (2)

• web/src/main/java/org/phoenixctms/ctsms/web/component/datatable/DataTable.java (1 hunks)
• web/src/main/java/org/phoenixctms/ctsms/web/model/SessionScopeBean.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_datatable_pagereset

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rkrenn]

@CodeRabbit full review

[coderabbitai]

✅ Actions performed

Full review triggered.