Skip to content

homedosing visit type#384

Merged
rkrenn merged 3 commits intomasterfrom
homedosing
Aug 4, 2025
Merged

homedosing visit type#384
rkrenn merged 3 commits intomasterfrom
homedosing

Conversation

@rkrenn
Copy link
Copy Markdown
Collaborator

@rkrenn rkrenn commented Aug 4, 2025

Summary by CodeRabbit

  • New Features
    • Added a new visit type: Home dosing (visible, non-travel) with an olive color for easy identification.
    • Home dosing now appears in visit type selectors and related workflows.
    • Added labels for Home dosing in English (“home dosing”) and German (“Home-Dosing”) for localized displays.

@rkrenn rkrenn merged commit b57251c into master Aug 4, 2025
1 check passed
@rkrenn
Copy link
Copy Markdown
Collaborator Author

rkrenn commented Aug 15, 2025

@CodeRabbit full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 15, 2025

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new visit type "homedosing" across database migration, Java seeding, and localization properties, and increments the schema version to 010801100.

Changes

Cohort / File(s) Summary
DB Version Bump
core/db/schema-set-version.sql
Update final set_database_version argument from '010801099' to '010801100'.
DB Migration 010801100
core/db/schema-up-master.sql
New conditional block for upgrading to 010801100: insert visit_type (name_l10n_key='homedosing', color='OLIVE', visible=true, travel=false, max_occurrence=NULL), then set version to 010801100.
Java Seed Data
core/src/exec/java/org/phoenixctms/ctsms/executable/ProductionDataProvider.java
Add "homedosing" visit type to createVisitTypes() with color OLIVE, visible=true, travel=false, maxOccurrence=null.
Localization (EN/DE)
core/src/main/resources/ctsms-visittypes.properties, core/src/main/resources/ctsms-visittypes_de.properties
Add homedosing=home dosing (EN) and homedosing=Home-Dosing (DE). Existing keys unchanged.

Sequence Diagram(s)

sequenceDiagram
  participant App
  participant DB

  App->>DB: get_database_version()
  DB-->>App: current version
  alt version < 010801100
    App->>DB: INSERT visit_type (name_l10n_key='homedosing', color='OLIVE', visible=true, travel=false, max_occurrence=NULL)
    App->>DB: set_database_version('010801100')
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit typed with nimble paws,
“Homedosing” hops into our laws—
A splash of OLIVE, fields align,
Props translated, seeds in line.
Version ticked, migrations through—
Thump-thump! The schema’s fresh and new. 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.38.6)
core/src/exec/java/org/phoenixctms/ctsms/executable/ProductionDataProvider.java

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 41df50f and bec882b.

📒 Files selected for processing (5)
  • core/db/schema-set-version.sql (1 hunks)
  • core/db/schema-up-master.sql (1 hunks)
  • core/src/exec/java/org/phoenixctms/ctsms/executable/ProductionDataProvider.java (1 hunks)
  • core/src/main/resources/ctsms-visittypes.properties (1 hunks)
  • core/src/main/resources/ctsms-visittypes_de.properties (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch homedosing

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant