Skip to content

job progress bar#405

Merged
rkrenn merged 3 commits intomasterfrom
job_progress
Feb 5, 2026
Merged

job progress bar#405
rkrenn merged 3 commits intomasterfrom
job_progress

Conversation

@rkrenn
Copy link
Copy Markdown
Collaborator

@rkrenn rkrenn commented Feb 4, 2026

image

Summary by CodeRabbit

Release Notes

  • New Features
    • Added visual progress bar to the job list displaying progress as a percentage with current/maximum values
    • Added total charge column to the ECRF progress overview for improved financial visibility
    • Progress tracking now includes localized labels in English and German

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

This pull request adds job progress tracking functionality across the database schema, backend Java layer, localization resources, and UI components. It introduces two new columns (PROGRESS and PROGRESS_MAX) to the JOB table, adds progress calculation methods to JobBean, and displays a progress bar in the job list interface with English and German localization. Multiple UML profile metadata identifiers are also updated with no semantic changes.

Changes

Cohort / File(s) Summary
Database Schema Updates
core/db/schema-create.sql, core/db/schema-set-version.sql, core/db/schema-up-master.sql
Added PROGRESS and PROGRESS_MAX nullable BIGINT columns to the JOB table with schema version bump from 010801105 to 010801106.
Java Backend Logic
web/src/main/java/org/phoenixctms/ctsms/web/model/shared/JobBean.java, web/src/main/java/org/phoenixctms/ctsms/web/util/MessageCodes.java
Added getProgressLabel() and getProgressValue() methods to JobBean for calculating and formatting progress display, plus new JOB_PROGRESS_LABEL constant in MessageCodes.
Localization - Labels
web/src/main/resources/org/phoenixctms/ctsms/web/labels.properties, web/src/main/resources/org/phoenixctms/ctsms/web/labels_de.properties
Added job_job_list_progress_column property for "Progress" column header in English and German ("Fortschritt").
Localization - Messages
web/src/main/resources/org/phoenixctms/ctsms/web/messages.properties, web/src/main/resources/org/phoenixctms/ctsms/web/messages_de.properties
Added job_progress_label message pattern "{0}/{1}" for displaying progress as current/maximum values in both languages.
UI Components
web/src/main/webapp/META-INF/includes/shared/job.xhtml, web/src/main/webapp/trial/ecrfProgressOverview.xhtml
Added progress bar column to job list table using JobBean helper methods; repositioned total charge column in ecrf progress overview table.
UML Profile Metadata
mda/src/main/uml/UML_Standard_Profile.StandardProfileL3.profile.uml, mda/src/main/uml/andromda-common.andromda-service.profile.uml, mda/src/main/uml/andromda-presentation.profile.uml, mda/src/main/uml/andromda-process.profile.uml, mda/src/main/uml/andromda-webservice.profile.uml, mda/src/main/uml/andromda-xml.profile.uml
Updated internal XMI element IDs, eAnnotations references, and metadata identifiers across multiple UML profiles; no semantic or structural changes to profile content.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

Suggested reviewers

  • SigridDeller
  • fladi

Poem

🐰 Hop hop, progress bars now hop!
Job tracking won't ever stop,
From database to UI display,
Progress marches on its way!
German labels, English too,
All translated just for you!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'job progress bar' directly corresponds to the primary change: adding a progress bar feature to the job management interface with database columns (PROGRESS, PROGRESS_MAX), UI components, and localization support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch job_progress

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rkrenn rkrenn merged commit f36f0d4 into master Feb 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant