`new phx.gen.auth ...` choosing LiveView fails to inject menu items in layouts

[kEND]

Environment

• Elixir version (elixir -v): Elixir 1.14.0 (compiled with Erlang/OTP 25)
• Phoenix version (mix deps): phoenix 1.7.0-rc.0 aead257
• Operating system: macOS 12.3.1

Goal: try out the new LiveView-based auth on a blank 1.7.0-rc.0 project.

1. mix phx.new dev_app and follow prompts to get deps and create a database.
2. mix phx.gen.auth Accounts User users choosing 'Y' for LiveView based system.

Expected behavior

Do you want to create a LiveView based authentication system? [Yn] Y
* creating priv/repo/migrations/20221222005622_create_users_auth_tables.exs
* creating lib/dev_app/accounts/user_notifier.ex
...

dev_app/ ~

Actual behavior

The auth menu items are not injected into the layout files.

* injecting lib/dev_app_web/router.ex - plug

Unable to find an application layout file to inject user menu items.

Missing files:

  * lib/dev_app_web/templates/layout/root.html.heex
  * lib/dev_app_web/templates/layout/app.html.heex

Please ensure this phoenix app was not generated with
--no-html. If you have changed the name of your application
layout file, please add the following code to it where you'd
like the user menu items to be rendered.

    <ul>
      <%= if @current_user do %>
        <li>
          <%= @current_user.email %>
        </li>
        <li>
          <.link href={~p"/users/settings"}>Settings</.link>
        </li>
        <li>
          <.link href={~p"/users/log_out"} method="delete">Log out</.link>
        </li>
      <% else %>
        <li>
          <.link href={~p"/users/register"}>Register</.link>
        </li>
        <li>
          <.link href={~p"/users/log_in"}>Log in</.link>
        </li>
      <% end %>
    </ul>


Please re-fetch your dependencies with the following command:

[kEND]

I'm working on adding a test (and then hopefully a PR) to expose this issue.

Can you confirm this is still an issue, I think this has been possibly addressed.

[kEND]

I'll retest this and #5177 and report back.

[ghenry]

Hi all,

Just playing with v1.7.0-rc.1 and notice the menu items are there, but not themed very nice:

everything else looks amazing with Tailwindcss bundled in now and the new defaults.

Thanks!

[jeregrine]

Looks like the only thing we need to do is update the live auth generators to use the new components in core_components.

I would happily accept a PR for this exact change.

[fabrithedev]

@jeregrine

I've made a simple solution that added just some styles into menu (1 line of code) and updated the tests.
If its enough i can make a PR.

Home:

logged in:

[jeregrine]

looks like someone took a stab at it here https://github.com/phoenixframework/phoenix/pull/5090/files

[derpycoder]

@vanderhoop is working on this.

#5090