Skip to content

Conversation

@baldmountain
Copy link

Based on discussion on elixir-forum about brunch not being maintained I figured rather than griping about it I'd contribute some code. This PR adds an npm option to generate npm scripts to maintain javascript and css assets. This isn't meant to be the final solution. I'm not an expert at JavaScript/CSS build pipelines so I may have done a few things wrong. It's a starting point for conversation and contributions from folks who know more.

  • All tests pass.
  • The default is to use npm scripts rather than brunch.
  • It generates a valid working project (at least with no-ecto) and includes watching app.js and app.css.
  • Using npm should imply --no-brunch but isn't handled properly
  • Probably some other issue too.

@chrismccord
Copy link
Member

Thanks! I'm not ready at this point to make a change with our js tooling but we can use this as reference should we decide to use npm scripts in the future.

@chrismccord chrismccord closed this Feb 2, 2018
@danschultzer
Copy link

The discussion can be found here: https://elixirforum.com/t/potentially-removing-brunch-from-the-phoenix-new-template-generator/2454

Thanks, @baldmountain! We got a production app where we badly need to get away from brunch, and I had plans to make a working example too. We'll try this out, and I'll report back asap 😄

The production app we got going has a complex but common setup of assets that should make it an ideal testing ground!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants