Fix outdated flash component example in docs#6631
Merged
SteffenDE merged 1 commit intophoenixframework:mainfrom Mar 20, 2026
Merged
Fix outdated flash component example in docs#6631SteffenDE merged 1 commit intophoenixframework:mainfrom
SteffenDE merged 1 commit intophoenixframework:mainfrom
Conversation
The example used `show("#flash")` which does not match the default
generated id (`flash-#{kind}`), and was missing the `hidden` attribute
needed for `phx-mounted` to work correctly.
Updated to follow the same pattern used by the server-error and
client-error flashes in the generated layouts.
Closes phoenixframework#6624
Contributor
|
🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flash component
@docexample usedshow("#flash")which had two issues:#flashdoes not match the default generated id (flash-#{kind})hiddenattribute, sophx-mountedhad no visible effectUpdated the example to follow the same pattern used by the
client-errorandserver-errorflashes in the generated layouts: explicitid,hiddenattribute,and
show("#id") |> JS.remove_attribute("hidden").Closes #6624