Fix phx.new crash when parent directory contains a colon#6633
Open
eagle-head wants to merge 1 commit intophoenixframework:mainfrom
Open
Fix phx.new crash when parent directory contains a colon#6633eagle-head wants to merge 1 commit intophoenixframework:mainfrom
eagle-head wants to merge 1 commit intophoenixframework:mainfrom
Conversation
The `:binding` expansion regex in `Project.expand_path_with_bindings/2` was applied to the full absolute path, causing colons in parent directories (e.g., `/mnt/usb-Seagate:0/code`) to be incorrectly interpreted as template bindings. Now the binding expansion is applied only to the relative template path before joining with the base path. Closes phoenixframework#6585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mix phx.newcrashes with aKeyErrorwhen the parent directorycontains a colon (e.g.,
/mnt/usb-Seagate:0/code/myapp).The regex in
Project.expand_path_with_bindings/2matches:[a-zA-Z0-9_]+against the full absolute path, so a directorylike
0:0causes:0to be interpreted as a template binding.The fix applies the binding expansion only to the relative template
path before joining it with the base path.
To reproduce (before fix)
After fix
Closes #6585