Correctly serialize non ASCII metadata#6664
Open
lukaszsamson wants to merge 1 commit intophoenixframework:mainfrom
Open
Correctly serialize non ASCII metadata#6664lukaszsamson wants to merge 1 commit intophoenixframework:mainfrom
lukaszsamson wants to merge 1 commit intophoenixframework:mainfrom
Conversation
SteffenDE
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes serialization of non ASCII topic metadata. It also adds assert on byte size matchin asserts on server side in lib/phoenix/socket/serializers/v2_json_serializer.ex which limit fields to 255 bytes
Fixes #6663
With this patch Repro https://github.com/lukaszsamson/phoenix-serializer-bug-repro works correctly:
Server:
Client: