chore: merge all open feature branches into dev#300
Merged
JustAGhosT merged 25 commits intodevfrom Mar 7, 2026
Merged
Conversation
…UI elements The full-tier editor theme was only mapping ~20 VS Code color keys, leaving many surfaces (panels, terminal, inputs, dropdowns, menus, breadcrumbs, notifications, peek views, scrollbars, minimap) at VS Code's default black. Added 55+ additional dark mode color mappings to editor-theme.yaml covering: - Panel/terminal backgrounds and foregrounds - Input fields and dropdowns - Breadcrumb navigation - Scrollbar sliders - Notifications and quick input (command palette) - Peek view surfaces - Context menus - Borders between all major UI sections - List hover/focus states - Editor widget surfaces - Tab borders and active border indicators All new mappings resolve to existing brand.yaml dark mode tokens (background #18232A, surface #23303A, textPrimary #F7F9FB, textSecondary #B4BAC2). https://claude.ai/code/session_01LWBsX863t5HD5VQnnQfff8
…me with light-mode parity
- Add scripts/filter-theme-tier.js: filters editor-theme.yaml keys by
tier setting (minimal/medium/full) with accumulation semantics
- Add scripts/editor-theme-staged.yaml: complete replacement for
.agentkit/spec/editor-theme.yaml with:
- Light mode brought to 77 keys (parity with dark mode)
- 11 new surface groups: panel, terminal, input, dropdown, breadcrumb,
scrollbar, notifications, quick input, peek view, minimap, menu
- Tier section markers (# --- tier: minimal|medium|full ---)
- Contrast fixes: statusBar.foreground, badge.foreground (light),
list.activeSelectionForeground (dark) use neutral.900 for WCAG AA
To apply: cp scripts/editor-theme-staged.yaml .agentkit/spec/editor-theme.yaml
Then: pnpm -C .agentkit agentkit:sync
https://claude.ai/code/session_01LWBsX863t5HD5VQnnQfff8
… all VS Code color keys Staged replacement for .agentkit/overlays/__TEMPLATE__/editor-theme.yaml. Expands the overlay template from ~29 lines to a comprehensive reference covering all VS Code workbench.colorCustomizations keys organized by: - Tier markers (minimal / medium / full) - 30 surface groups: title bar, activity bar, status bar, sidebar, editor (selection, find, highlight, cursor, bracket, gutter, ruler, suggest, code lens), diff editor, tabs, badges, lists & trees, buttons, panel, terminal (+ 16 ANSI colors), input fields (+validation), dropdowns, breadcrumbs, scrollbar, notifications, quick input, peek view, minimap, menus, git decorations, merge conflicts, debug, testing, welcome page, settings editor, keybinding labels, and global focus/selection tokens - Brand token reference guide in header comments - Per-tool override section (cursor, windsurf) To apply: cp scripts/overlay-editor-theme-staged.yaml \ .agentkit/overlays/__TEMPLATE__/editor-theme.yaml https://claude.ai/code/session_01LWBsX863t5HD5VQnnQfff8
Removed the unused `readFileSync` import from `.agentkit/engines/node/src/handoff.mjs` to improve code cleanliness. Co-authored-by: JustAGhosT <5531814+JustAGhosT@users.noreply.github.com>
Replace regex-based replacement with literal string replacement in scripts/create-doc.ps1 and scripts/create-doc.sh to prevent injection vulnerabilities from unescaped user input. Co-authored-by: JustAGhosT <5531814+JustAGhosT@users.noreply.github.com>
Co-authored-by: JustAGhosT <5531814+JustAGhosT@users.noreply.github.com>
Updates 27 docs/ files and 2 template/framework files to replace old numbered directory paths (01_product/, 02_specs/, etc.) with the current unnumbered structure (product/, architecture/specs/, etc.). Context-aware relative path corrections for files at different nesting levels (e.g., architecture/specs/ files use ../../api/ instead of ../04_api/). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add docCategoryList shared section to sections.yaml (single source of
truth for the 8-category docs structure)
- Add orchestration and integrations categories to docs.yaml
- Update documentation rule template to use {{shared_docCategoryList}}
instead of hardcoded bullet list
- Fix [02_decisions/] stale link text in 01_overview.md template
- Add orchestration/ to QUICK_START.md directory listing
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Updates documentation directory structure from numbered prefixes to simplified category names, aligning with domain-driven structure. Removes obsolete editor config files (.cursor, .windsurf) and updates all cross-references in documentation files to reflect the new structure.
- Fix merge conflicts in documentation.md and cli_delivery_improvements_milestone.md - Format documentation list with proper bullet points - Update security advisory URL in GitHub issue template - Update CONTRIBUTING.md to use 'develop' branch for feature branches - Add README.md files to docs/agents and docs/orchestration directories - Add convenient npm scripts for AgentKit setup, install, sync and validate - Add pnpm-setup.sh script for easier onboarding - Update README.md with simplified setup commands
- CONTRIBUTING.md: replace `develop` with `dev` to match actual branch, add PR summary/test plan requirement and CODEOWNERS approval note - README.md: update script names from `pnpm run setup/install/sync/validate` to `pnpm run ak:setup/ak:install/ak:sync/ak:validate` matching package.json - docs/history/.index.json: zero out sequence counts for types with no entries (feature, migration, issue, lesson) - pnpm-setup.sh: add `set -euo pipefail` for fail-fast error handling https://claude.ai/code/session_01PcWC8LJJtKB4otjq7CU7u5
Change pnpm-setup.sh shebang from #!/bin/sh to #!/usr/bin/env bash since `set -euo pipefail` requires bash (pipefail is not POSIX). Also includes regenerated sync output (timestamp updates). https://claude.ai/code/session_01PcWC8LJJtKB4otjq7CU7u5
- Restore P1 adopter autoupdate backlog item with PRD-007 link and milestone footnote that was accidentally removed (AGENT_BACKLOG.md) - Revert branch references from `dev` back to `main` to match the canonical default branch (CONTRIBUTING.md) - Untrack .claude/settings.local.json (already in .gitignore but was still tracked, adding Windows-path noise to diffs) - Restore multiline JSON formatting in docs/history/.index.json for readability - Set executable permission on pnpm-setup.sh https://claude.ai/code/session_01PcWC8LJJtKB4otjq7CU7u5
#296) Remove unused readFileSync import in handoff.mjs.
…#294) Fix regular expression injection in create-doc scripts.
Add task-types.mjs unit tests.
Sync editor theme and settings across all IDE configurations.
Update branch naming and npm scripts conventions. # Conflicts: # .agentkit/docs/getting-started/QUICK_START.md # .cursor/settings.json # .github/instructions/README.md # .github/instructions/code-verify.md # .github/instructions/docs.md # .github/instructions/languages/README.md # .github/instructions/languages/agent-conduct.md # .github/instructions/languages/blockchain.md # .github/instructions/languages/ci-cd.md # .github/instructions/languages/dependency-management.md # .github/instructions/languages/documentation.md # .github/instructions/languages/dotnet.md # .github/instructions/languages/finops.md # .github/instructions/languages/git-workflow.md # .github/instructions/languages/iac.md # .github/instructions/languages/python.md # .github/instructions/languages/rust.md # .github/instructions/languages/security.md # .github/instructions/languages/template-protection.md # .github/instructions/languages/testing.md # .github/instructions/languages/typescript.md # .github/instructions/marketing.md # .github/instructions/performance.md # .github/instructions/quality.md # .github/instructions/testing.md # .windsurf/settings.json # AGENT_BACKLOG.md # docs/agents/README.md # docs/architecture/decisions/02-fallback-policy-tokens-problem.md # docs/orchestration/README.md # docs/reference/cli_delivery_improvements_milestone.md # pnpm-setup.sh
The tests verify that the array contains the expected task types, matches the exact expected array, is frozen to prevent modification, and throws errors when mutation is attempted. Also removes unused imports from handoff.mjs.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds tests for VALID_TASK_TYPES, removes an unused fs import, hardens doc-generation scripts, introduces a tiered editor-theme spec with filtering and overlay scaffolds, and synchronizes IDE theme settings across multiple config files. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Mar 7, 2026
This was referenced Mar 7, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.agentkit/spec/editor-theme.yaml (1)
1-3:⚠️ Potential issue | 🔴 CriticalRun
pnpm -C .agentkit agentkit:syncand commit the regenerated outputs before pushing.After editing files in
.agentkit/spec/, you must runpnpm -C .agentkit agentkit:syncand commit the regenerated outputs. The CI drift check will fail otherwise.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agentkit/spec/editor-theme.yaml around lines 1 - 3, You edited editor-theme.yaml under the agentkit spec; run the sync command to regenerate outputs and commit them: execute pnpm -C .agentkit agentkit:sync (as stated) to regenerate generated files, review the changes, and add/commit the updated outputs before pushing so the CI drift check passes.
🧹 Nitpick comments (1)
__tests__/task-types.test.mjs (1)
29-39: Split the two mutation checks into separate specs.
push()failure and indexed assignment failure are distinct behaviors. Keeping them in oneit(...)makes the failure less specific when only one path regresses.Based on learnings: Every test body must follow the Arrange-Act-Assert (AAA) pattern and keep each test focused on a single behaviour; split compound assertions into separate tests.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@__tests__/task-types.test.mjs` around lines 29 - 39, Split the combined mutation spec into two focused tests: replace the single it(...) that asserts both push() and indexed assignment throw with two separate specs—one it('throws an error when trying to push to the array', ...) that only asserts VALID_TASK_TYPES.push('new-task') throws a TypeError, and a second it('throws an error when trying to assign by index', ...) that only asserts VALID_TASK_TYPES[0] = 'modified' throws a TypeError; keep the // `@ts-expect-error` comments and use the same expect(...).toThrow(TypeError) assertions for each new spec so failures map to the exact behavior (references: VALID_TASK_TYPES in __tests__/task-types.test.mjs).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.agentkit/engines/node/src/handoff.mjs:
- Around line 6-10: The save-path file operations in runHandoff call existsSync,
mkdirSync, and writeFileSync but the module no longer imports fs; re-add the
missing imports by importing those functions from 'fs' (e.g., import {
existsSync, mkdirSync, writeFileSync } from 'fs') at the top of the file so
runHandoff(..., { save: true }) can create the directory and write the handoff
file without a ReferenceError.
---
Outside diff comments:
In @.agentkit/spec/editor-theme.yaml:
- Around line 1-3: You edited editor-theme.yaml under the agentkit spec; run the
sync command to regenerate outputs and commit them: execute pnpm -C .agentkit
agentkit:sync (as stated) to regenerate generated files, review the changes, and
add/commit the updated outputs before pushing so the CI drift check passes.
---
Nitpick comments:
In `@__tests__/task-types.test.mjs`:
- Around line 29-39: Split the combined mutation spec into two focused tests:
replace the single it(...) that asserts both push() and indexed assignment throw
with two separate specs—one it('throws an error when trying to push to the
array', ...) that only asserts VALID_TASK_TYPES.push('new-task') throws a
TypeError, and a second it('throws an error when trying to assign by index',
...) that only asserts VALID_TASK_TYPES[0] = 'modified' throws a TypeError; keep
the // `@ts-expect-error` comments and use the same expect(...).toThrow(TypeError)
assertions for each new spec so failures map to the exact behavior (references:
VALID_TASK_TYPES in __tests__/task-types.test.mjs).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2cd14554-345b-4933-ab7e-21e8c83050f7
📒 Files selected for processing (15)
.agentkit/engines/node/src/__tests__/task-types.test.mjs.agentkit/engines/node/src/handoff.mjs.agentkit/spec/editor-theme.yaml.cursor/settings.json.github/ISSUE_TEMPLATE/config.yml.vscode/settings.json.windsurf/settings.jsonAGENT_BACKLOG.md__tests__/task-types.test.mjspnpm-setup.shscripts/create-doc.ps1scripts/create-doc.shscripts/editor-theme-staged.yamlscripts/filter-theme-tier.jsscripts/overlay-editor-theme-staged.yaml
existsSync, mkdirSync, and writeFileSync are used in runHandoff when the --save flag is passed, but were never imported after readFileSync was removed in PR #296. This would cause a ReferenceError at runtime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AgentKit Forge Source Change DetectedThis PR modifies files in the AgentKit Forge source directories:
These are the upstream source-of-truth for all generated AI tool configs. Review checklist
|
This was referenced Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidation PR that merges all 5 remaining open feature branches into
devin a single, conflict-resolved branch.Branches merged (in order)
fix-remove-unused-import-handoffreadFileSyncimport inhandoff.mjsfix-regex-injection-create-doccreate-docscriptsfix/add-task-types-teststask-types.mjsunit testsclaude/fix-full-tier-black-elementsclaude/review-agent-guidelinesConflict resolution
scripts/resolve-merge.sh:.github/instructions/files → KEEP_OURS (dev has latest sync output).cursor/settings.json,.windsurf/settings.json) → KEEP_OURS (merge Fix healthcheck test timeout by using temp directory #4 added theme updates)docs/agents/,docs/orchestration/) → KEEP_OURSQUICK_START.md,cli_delivery_improvements_milestone.md→ KEEP_OURS (already fixed in PR fix(docs): remove stale numbered directory references across codebase #297)AGENT_BACKLOG.md→ KEEP_THEIRS (has autoupdate task + milestone note)ADR 02date → KEEP_OURS (2026-03-07, more recent)pnpm-setup.sh→ KEEP_THEIRS (#!/usr/bin/env bash+set -euo pipefailis stricter)Closes
Closes #296, closes #294, closes #295, closes #285, closes #298
Test plan
git merge-treedry-rungrep -rn "^<<<<<<<"clean)🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Tests