Skip to content

chore(issues): update follow-up issues after kit-based domain filtering#435

Merged
JustAGhosT merged 1 commit intomainfrom
chore/phase5-issue-cleanup
Mar 21, 2026
Merged

chore(issues): update follow-up issues after kit-based domain filtering#435
JustAGhosT merged 1 commit intomainfrom
chore/phase5-issue-cleanup

Conversation

@JustAGhosT
Copy link
Copy Markdown
Collaborator

Summary

  • Marks 006 (CLI-spec parity) as Resolved — framework command types and Phase 10 parity check merged via PR feat(engine): kit-based domain selection, init wizard, stop hook perf #432
  • Marks 040 (elegance-guidelines) as Resolvedelegance-guidelines field merged into agents.yaml via PR feat(engine): kit-based domain selection, init wizard, stop hook perf #432
  • Marks 025 (TRAE rules) as Partially resolvedfilterDomainsByStack() addresses domain noise; TRAE format audit remains outstanding
  • Updates 026 (TRAE skills) as In progress / follow-up needed — same filtering principle applies to skills
  • Marks 027 (TRAE agents) as Deferred — TRAE packaging/import format audit not yet started
  • Downgrades 004 (rules.yaml ownership) from P2 → P3 — domain filtering reduces governance urgency

Test plan

  • grep -r "## Resolution\|## Note\|## Status" .github/ISSUES/*.md confirms all 6 files updated
  • CI passes (markdown-only changes, no spec drift)

🤖 Generated with Claude Code

- 006: mark Resolved — CLI-spec parity check and framework command types merged via PR #432
- 040: mark Resolved — elegance-guidelines field added to agents.yaml via PR #432
- 025: mark Partially resolved — filterDomainsByStack() addresses noise; TRAE format audit outstanding
- 026: mark In progress — kit filtering principle extends to skills; TRAE format audit pending
- 027: mark Deferred — TRAE agent packaging/import format audit not yet started
- 004: reduce priority P2 → P3 — domain filtering reduces governance urgency for rules.yaml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@blocksorg
Copy link
Copy Markdown

blocksorg bot commented Mar 21, 2026

Mention Blocks like a regular teammate with your question or request:

@blocks review this pull request
@blocks make the following changes ...
@blocks create an issue from what was mentioned in the following comment ...
@blocks explain the following code ...
@blocks are there any security or performance concerns?

Run @blocks /help for more information.

Workspace settings | Disable this message

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9aa363a2-51ad-4a00-b086-a7d77c2b374b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/phase5-issue-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JustAGhosT JustAGhosT merged commit e3e94cb into main Mar 21, 2026
3 of 14 checks passed
@JustAGhosT JustAGhosT deleted the chore/phase5-issue-cleanup branch March 21, 2026 03:56
JustAGhosT added a commit that referenced this pull request Mar 21, 2026
Resolves conflicts from reverse-merge PR #437 (main → dev).
Main had 2 commits that dev was missing:
- chore(issues): update follow-up issues after kit-based domain filtering (#435)
- feat(rename): rebrand CLI from agentkit to retort with deprecated alias (#436)

Conflict resolution strategy:
- Engine source files (.mjs): keep dev version (more complete — has domain
  filtering, backward-compat header checks, kit detection in init.mjs)
- Template files: keep dev version (fixes "an Retort" → "a Retort" grammar)
- .github/ISSUES/006: take main's ## Resolution section (phase 5 work)
- .github/ISSUES/040: keep dev's Retort branding + add main's ## Resolution

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant