Improve doctor.mjs test suite based on review feedback#69
Merged
JustAGhosT merged 3 commits intoadd-doctor-tests-10176394997023626905from Feb 28, 2026
Merged
Improve doctor.mjs test suite based on review feedback#69JustAGhosT merged 3 commits intoadd-doctor-tests-10176394997023626905from
JustAGhosT merged 3 commits intoadd-doctor-tests-10176394997023626905from
Conversation
Co-authored-by: JustAGhosT <5531814+JustAGhosT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for doctor.mjs to improve code coverage
Improve doctor.mjs test suite based on review feedback
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original
doctor.test.mjshad structural issues: repeatedawait import()calls per-test, incorrect test naming, informal comments, missing coverage for several code paths, and no tests for theverboseflag.Changes
Mock setup refactored
validateSpecimported at top level; default mock set inbeforeEachinstead of per-test dynamic importsvi.mock('fs')retained — required in ESM to make named exports configurable forvi.spyOnTest quality fixes
"should report error if overlay settings file is missing"→"should report warning ..."(matches actual behavior)New coverage
project.yamlinvalid YAML triggerserrorfinding (previously untested catch block)project.yamlcompleteness test now asserts both theinfopercentage finding and theTop missing high-impact fieldswarningVerbose flag tests (3 new)
flags.verboseprints suggested next actions for each status (FAIL,WARN,PASS)Refactor
getConsoleOutput()helper to eliminate duplication across verbose testsfindingWithUnknownTarget→unknownTargetFinding💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.