Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

added Azure server-side example#1124

Merged
macdonst merged 2 commits intophonegap:masterfrom
Mikejo5000:master
Aug 15, 2016
Merged

added Azure server-side example#1124
macdonst merged 2 commits intophonegap:masterfrom
Mikejo5000:master

Conversation

@Mikejo5000
Copy link
Copy Markdown
Contributor

Description

Added an example of doing push in a node.js backend from Azure using an
Azure Mobile App, push notification hubs, and push notification templates.

Related Issue

Motivation and Context

There are various examples of using the plugin server-side such as ADM, but none for Azure.

How Has This Been Tested?

This has been tested in Cordova apps against Android, iOS, and Windows. It is the same code found in the official Azure documentation here:
https://azure.microsoft.com/en-us/documentation/articles/app-service-mobile-cordova-get-started-push/#add-push-to-app

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@macdonst
Copy link
Copy Markdown
Member

macdonst commented Aug 3, 2016

@Mikejo5000 do you think you can write some markdown to go with this file describing how to use it?

Comment thread example/server/pushAzure.js Outdated
@@ -0,0 +1,52 @@
// ----------------------------------------------------------------------------
// Copyright (c) 2015 Microsoft Corporation. All rights reserved.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly worried about putting a MS copyrighted file into the repo. I know you work for MS but I don't want to run afoul of your legal team after some automated scan of github repos. How can we show you have permissions to add this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with the MS owners of the code; they told me to remove the copyright since I had modified the file (I've removed it in an update). Apparently, the copyright info only applies to the unmodified version (which I did not use).

@Mikejo5000
Copy link
Copy Markdown
Contributor Author

@macdonst I included two links to key documents in the comments for the code. The complete E2E process seems like a lot of information for this page. If you think a task summary with links for more info is better than the links in the comments, I will be happy to do that.

@macdonst macdonst merged commit 0bd4d0e into phonegap:master Aug 15, 2016
@macdonst
Copy link
Copy Markdown
Member

@Mikejo5000 Merged, thanks for the PR. I know people will find the information useful. I just wish I had time to use all of the backends.

@lock
Copy link
Copy Markdown

lock Bot commented Jun 3, 2018

This thread has been automatically locked.

@lock lock Bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants