docs(cli): update for Node.js environment#23
Conversation
The npm bundle now targets Node.js (shebang #!/usr/bin/env node, build --target node). Update CLI docs to reflect: - Remove Bun shebang requirement note from installation - Change global install from `bun add -g` to `npm install -g` - Simplify one-off section to npx (no longer needs Bun on PATH) - Add note that Node >= 18 is sufficient, Bun is optional - Update description to match new tagline Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughDocs update: overview now brands “Photon CLI” and adds a Node.js >= 18 requirement; installation page removes Bun-specific phrasing, simplifies Homebrew notes, shows a pnpx one-off example, and consolidates global install commands into a CodeGroup including npm/pnpm/yarn/bun. ChangesCLI Documentation
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates the CLI documentation to reflect the npm package now targeting Node.js instead of requiring Bun, while keeping Bun as an optional install path.
Changes:
- Updates CLI overview tagline and adds Node.js >= 18 runtime note.
- Revises installation docs to prefer
npxandnpm install -g. - Removes Bun-specific one-off guidance and clarifies Bun is optional.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cli/overview.mdx |
Updates description metadata and adds Node.js runtime note. |
cli/installation.mdx |
Updates one-off and global install instructions for npm/Node.js. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/installation.mdx`:
- Around line 28-40: Rename the section heading "## Global install with npm" to
a neutral title that reflects both commands (for example "## Global install" or
"## Global install with npm or Bun") so it matches the contents inside the
CodeGroup showing both npm and bun install commands; update the heading text
only (leave the CodeGroup block and the two install command snippets unchanged).
- Line 49: The runtime note "The npm bundle runs on Node.js >= 18. Bun is also
supported but not required." should be rewritten in second person and active
voice to address the reader directly; replace it with a sentence such as "You
can run the npm bundle on Node.js >= 18; you can also use Bun, but you don't
need it." Ensure the new sentence preserves the same facts and tone, uses "you"
and active verbs, and replaces the original sentence in cli/installation.mdx.
In `@cli/overview.mdx`:
- Line 12: The runtime requirement sentence "Runs on Node.js >= 18 — no
additional runtime required." should be rewritten in second person and active
voice; replace it with a line addressing the reader directly (e.g., "You can run
Photon CLI on Node.js >= 18 with no additional runtime.") so update the runtime
requirement note in cli/overview.mdx accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5384c761-921e-4570-ba43-3b3c7a772be6
📒 Files selected for processing (2)
cli/installation.mdxcli/overview.mdx
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Agent
🧰 Additional context used
📓 Path-based instructions (1)
**/*.mdx
📄 CodeRabbit inference engine (AGENTS.md)
**/*.mdx: Pages should be written as MDX files with YAML frontmatter
Use active voice and second person ("you") in documentation
Keep sentences concise with one idea per sentence in documentation
Use sentence case for headings in documentation
Bold UI elements in documentation (e.g., Click Settings)
Use code formatting for file names, commands, paths, and code references in documentation
Files:
cli/installation.mdxcli/overview.mdx
🔇 Additional comments (1)
cli/overview.mdx (1)
3-3: LGTM!
- One-off section: npx / pnpx / bunx tabs - Global install: npm / pnpm / yarn / bun tabs - Comment out Homebrew section (not ready yet) - Bun no longer a hard dependency, Node >= 18 is sufficient Co-authored-by: Cursor <cursoragent@cursor.com>
Addresses CodeRabbit feedback on #23. Co-authored-by: Cursor <cursoragent@cursor.com>
| ```sh pnpx | ||
| pnpx @photon-ai/cli login | ||
| pnpx @photon-ai/cli projects ls | ||
| ``` | ||
|
|
||
| ```sh bunx | ||
| bunx @photon-ai/cli login | ||
| bunx @photon-ai/cli projects ls |
Summary
bun add -gtonpm install -g(with Bun as alternative)npx(no longer needs Bun on PATH)Follows up on photon-hq/cli#20 which switched the npm bundle to
--target node.Test plan
Made with Cursor
Need help on this PR? Tag
@codesmithwith what you need.Summary by CodeRabbit