-
Notifications
You must be signed in to change notification settings - Fork 465
Add purge command #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add purge command #117
Conversation
|
I suggest to have a confirmation before executing the purge. This can be a critical mistake if you purge in prod. |
|
If we have a confirmation, there should be a way to override it, for sysadmins |
|
Maybe with an optional parameter |
|
ping @passkey1510 |
|
Hi there, I was lost in my GitHub notifications :). I've just introduced the "no-confirmation" option in the command. Tell me if it looks good for you guys. |
|
I think it's better with the confirmation. Can you squash your commits so @videlalvaro can merge your PR easily. |
|
The commits have been squashed! |
|
I suggest to add unit tests with this feature. We've experienced some issues recently with the bundle and i think it would be a good practice to add tests with every new feature. |
|
Just added an unit test for purge command |
|
Looks like good for me but i can't see the travis build. @videlalvaro have you configure the service hook? |
|
ping @videlalvaro |
Command/PurgeConsumerCommand.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This phpdoc is describing the class, not the method. So it should be at the class level
|
Any news on this? Would love to have an easy way to purge, would help with testing. |
|
👍 |
1 similar comment
|
👍 |
|
Sorry for missing this one. I think the missing step would be to document the feature on the README and then I hit the green button |
|
Thanks @videlalvaro! |
|
Hi @ch3ric and @videlalvaro, I've just merge the PR to update the README file. Please considering merging this feature :) |
|
@passkey1510 according to github there are merge conflicts |
|
@videlalvaro I've made a rebase on master, could you review this please? |
|
thanks @passkey1510 & @videlalvaro |
I think it could be helpful if the bundle has a command to purge a queue. I mainly need it in my unit tests as well as in deployment process to staging & preprod servers. In fact, I had to issue a purge command manually every time I deploy the application to these environments (to have a fresh instance running after each deployment).