Skip to content

Conversation

@passkey1510
Copy link
Contributor

I think it could be helpful if the bundle has a command to purge a queue. I mainly need it in my unit tests as well as in deployment process to staging & preprod servers. In fact, I had to issue a purge command manually every time I deploy the application to these environments (to have a fresh instance running after each deployment).

@blaugueux
Copy link
Contributor

I suggest to have a confirmation before executing the purge. This can be a critical mistake if you purge in prod.

@videlalvaro
Copy link
Collaborator

If we have a confirmation, there should be a way to override it, for sysadmins

@blaugueux
Copy link
Contributor

Maybe with an optional parameter --no-confirmation?

@videlalvaro
Copy link
Collaborator

ping @passkey1510

@passkey1510
Copy link
Contributor Author

Hi there, I was lost in my GitHub notifications :). I've just introduced the "no-confirmation" option in the command. Tell me if it looks good for you guys.

@blaugueux
Copy link
Contributor

I think it's better with the confirmation. Can you squash your commits so @videlalvaro can merge your PR easily.

@passkey1510
Copy link
Contributor Author

The commits have been squashed!

@blaugueux
Copy link
Contributor

I suggest to add unit tests with this feature. We've experienced some issues recently with the bundle and i think it would be a good practice to add tests with every new feature.

@passkey1510
Copy link
Contributor Author

Just added an unit test for purge command

@blaugueux
Copy link
Contributor

Looks like good for me but i can't see the travis build. @videlalvaro have you configure the service hook?

@passkey1510
Copy link
Contributor Author

ping @videlalvaro

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phpdoc is describing the class, not the method. So it should be at the class level

@evillemez
Copy link

Any news on this? Would love to have an easy way to purge, would help with testing.

@tyx
Copy link

tyx commented Sep 3, 2013

👍

1 similar comment
@ch3ric
Copy link

ch3ric commented Jan 20, 2014

👍

@videlalvaro
Copy link
Collaborator

Sorry for missing this one. I think the missing step would be to document the feature on the README and then I hit the green button

@ch3ric
Copy link

ch3ric commented Jan 21, 2014

Thanks @videlalvaro!
@passkey1510 ping passkey1510#1

@passkey1510
Copy link
Contributor Author

Hi @ch3ric and @videlalvaro, I've just merge the PR to update the README file. Please considering merging this feature :)

@videlalvaro
Copy link
Collaborator

@passkey1510 according to github there are merge conflicts

@passkey1510
Copy link
Contributor Author

@videlalvaro I've made a rebase on master, could you review this please?

videlalvaro added a commit that referenced this pull request Jan 27, 2014
@videlalvaro videlalvaro merged commit 69463ca into php-amqplib:master Jan 27, 2014
@ch3ric
Copy link

ch3ric commented Jan 27, 2014

thanks @passkey1510 & @videlalvaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants