-
Notifications
You must be signed in to change notification settings - Fork 465
Add multiple queues consumers #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you have a direct exchange, then these kind of routing keys have no effect. You can only use patterns with topic exchanges
|
@videlalvaro no remark on the pattern and its implementation? We followed your recommendation as per https://github.com/videlalvaro/RabbitMqBundle/pull/153#issuecomment-32798065 |
|
no remarks on that ;) |
|
Great! So you are okay to merge? |
|
yes, just fix those minor details, and then I'll press the bless button :P |
|
They are fixed by @joelwurtz since 4 hours. |
|
wow… didn't see the notification, I only got the email with your previous comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one detail, please remove this header, since we don't use them in the project. Credits for contributors are already part of git
|
ok, there was just one other minor detail, some PhpStorm auto header |
|
damn @joelwurtz. I wanted to use this feature officially tomorrow. Graoumph |
|
Hi, Should be good, do you want me to squash commits or it's ok ? |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
routing_keys instead of routing
Add multiple queues consumers
|
Thanks to everyone that made this feature possible. |
|
yeah! |
|
Thanks for reviewing this PR 🍺 |
|
👍 |
This PR add the possibility to link multiple queues with callback in the same consumer discuss in this issue
https://github.com/videlalvaro/RabbitMqBundle/pull/153 (I'm working with him :) )
We add it as the new pattern without modifying the existing one (like anon consumers).