Skip to content

Conversation

@joelwurtz
Copy link
Contributor

This PR add the possibility to link multiple queues with callback in the same consumer discuss in this issue
https://github.com/videlalvaro/RabbitMqBundle/pull/153 (I'm working with him :) )

We add it as the new pattern without modifying the existing one (like anon consumers).

@bastnic
Copy link
Contributor

bastnic commented Apr 23, 2014

👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have a direct exchange, then these kind of routing keys have no effect. You can only use patterns with topic exchanges

@bastnic
Copy link
Contributor

bastnic commented Apr 29, 2014

@videlalvaro no remark on the pattern and its implementation? We followed your recommendation as per https://github.com/videlalvaro/RabbitMqBundle/pull/153#issuecomment-32798065

@videlalvaro
Copy link
Collaborator

no remarks on that ;)

@bastnic
Copy link
Contributor

bastnic commented Apr 29, 2014

Great! So you are okay to merge?

@videlalvaro
Copy link
Collaborator

yes, just fix those minor details, and then I'll press the bless button :P

@bastnic
Copy link
Contributor

bastnic commented Apr 29, 2014

They are fixed by @joelwurtz since 4 hours.

@videlalvaro
Copy link
Collaborator

wow… didn't see the notification, I only got the email with your previous comments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one detail, please remove this header, since we don't use them in the project. Credits for contributors are already part of git

@videlalvaro
Copy link
Collaborator

ok, there was just one other minor detail, some PhpStorm auto header

@bastnic
Copy link
Contributor

bastnic commented Apr 29, 2014

damn @joelwurtz. I wanted to use this feature officially tomorrow. Graoumph

@joelwurtz
Copy link
Contributor Author

Hi,

Should be good, do you want me to squash commits or it's ok ?

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

routing_keys instead of routing

videlalvaro added a commit that referenced this pull request Apr 30, 2014
@videlalvaro videlalvaro merged commit dc6e65b into php-amqplib:master Apr 30, 2014
@videlalvaro
Copy link
Collaborator

Thanks to everyone that made this feature possible.

@bastnic
Copy link
Contributor

bastnic commented Apr 30, 2014

yeah!

@joelwurtz joelwurtz deleted the multiple-consumers branch April 30, 2014 14:58
@joelwurtz
Copy link
Contributor Author

Thanks for reviewing this PR 🍺

@tyx
Copy link

tyx commented Apr 30, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants