Fixed build log for invalid encoded utf8 characters. Issue #145.#146
Conversation
|
The logging works with my data. Can still not garante that every case is covered now... |
| return $outputs; | ||
| } | ||
|
|
||
| private static function replaceIllegalCharacters($utf8String) |
There was a problem hiding this comment.
PHPCensor\Helper\CommandExecutor::replaceIllegalCharacters::PHPCensor\Helper\CommandExecutor::replaceIllegalCharacters is missing a docblock.
| return $outputs; | ||
| } | ||
|
|
||
| private static function replaceIllegalCharacters($utf8String) |
There was a problem hiding this comment.
Class PHPCensor\Helper\CommandExecutor::replaceIllegalCharacters is missing a docblock.
Codecov Report
@@ Coverage Diff @@
## non-utf-8-fix #146 +/- ##
===================================================
+ Coverage 16.83% 16.87% +0.04%
- Complexity 3133 3134 +1
===================================================
Files 202 202
Lines 12736 12743 +7
===================================================
+ Hits 2144 2151 +7
Misses 10592 10592
Continue to review full report at Codecov.
|
|
to get cleaner history, this pr can be directly merged into master |
|
Merged. Thanks! 👍 |
3 participants
No description provided.