chore: update NEWS.txt cleanup leftovers after migration to RobotFramework.

Addressed to #530

No functional changes.

Author: php-coder

Dangerfile

@@ -608,7 +608,7 @@ if File.file?(spotbugs_report)
 	print_errors_summary 'spotbugs-maven-plugin', errors_count
 end
 
-# Handle `mvn robotframework:run` report
+# Handle `mvn robotframework:run` (`mvn verify`) report
 #
 # Example:
 # <suite source="/home/coder/mystamps/src/test/robotframework/category/access.robot" name="Access" id="s1-s1-s1">
@@ -661,48 +661,7 @@ if File.file?(rf_report)
 		file = github.html_link("#{file}#{line}")
 		fail("robotframework-maven-plugin error in #{file}:\nTest case `#{testcase}` fails with message:\n#{msg}")
 	end
-	# FIXME: add link to wiki page (#530)
-	print_errors_summary 'robotframework-maven-plugin', errors_count
-end
-
-# Handle `mvn verify`
-#
-# Example:
-# <testng-results skipped="0" failed="1" total="114" passed="113">
-#   <test name="When user at index page" duration-ms="559" started-at="2017-03-05T19:34:06Z" finished-at="2017-03-05T19:34:06Z">
-#     <class name="ru.mystamps.web.tests.cases.WhenUserAtIndexPage">
-#       <test-method status="FAIL" signature="shouldExistsLinkForListingCategories()[pri:0, instance:ru.mystamps.web.tests.cases.WhenUserAtIndexPage@2187fff7]" name="shouldExistsLinkForListingCategories" duration-ms="3" started-at="2017-03-05T20:34:06Z" finished-at="2017-03-05T20:34:06Z">
-#         <exception class="java.lang.AssertionError">
-#           <message>
-#             <![CDATA[should exists link to page for listing categories]]>
-#           </message>
-#           <full-stacktrace>
-#             <![CDATA[java.lang.AssertionError: should exists link to page for listing categories
-#             at ru.mystamps.web.tests.cases.WhenUserAtIndexPage.shouldExistsLinkForListingCategories(WhenUserAtIndexPage.java:78)
-#             at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
-#             ...
-#
-failsafe_report = 'target/failsafe-reports/testng-results.xml'
-if File.file?(failsafe_report)
-	errors_count = 0
-	doc = Nokogiri::XML(File.open(failsafe_report))
-	results  = doc.xpath('/testng-results').first
-	failures = results['failed'].to_i
-	if failures > 0
-		doc.xpath('//test-method[@status="FAIL"]').each do |node|
-			errors_count += 1
-			
-			clazz = node.parent['name']
-			file = 'src/test/java/' + clazz.gsub(/\./, '/') + '.java'
-			file = github.html_link(file)
-			testcase = clazz.split('.')[-1] + '.' + node['name']
-			msg = node.xpath('./exception/message').text.strip
-			# FIXME: highlight line number
-			fail("maven-failsafe-plugin error in #{file}:\nTest case `#{testcase}` fails with error:\n#{msg}")
-		end
-		
-		print_errors_summary 'maven-failsafe-plugin', errors_count, 'https://github.com/php-coder/mystamps/wiki/integration-tests'
-	end
+	print_errors_summary 'robotframework-maven-plugin', errors_count, 'https://github.com/php-coder/mystamps/wiki/integration-tests'
 end
 
 if github.pr_body !~ /Addressed to #\d+/

NEWS.txt

@@ -27,6 +27,7 @@
 - (functionality)  suggest a possible category on a series creation page
 - (functionality)  show similar series on a page with series info
 - (infrastructure) add ability to send e-mails via Mailgun API
+- (infrastructure) port the integration tests to Robot Framework. Also remove TestNG and FEST assertions
 
 0.3
 - (functionality)  implemented possibility to user to add series to his collection

README.md

@@ -45,5 +45,5 @@ If you are programmer/sysadmin or you just feeling that you are able to run a lo
 * *Validation*: JSR-303 (Hibernate Validator)
 * *Logging*: Slf4j (Logback)
 * *Unit tests*: Groovy and Spock Framework (for Java code), jasmine (for JavaScript code)
-* *Integration tests*: Selenium2, RobotFramework, WireMock, TestNG and fest-assert
+* *Integration tests*: Selenium2, RobotFramework, WireMock
 * *Others*: Lombok, Togglz, WebJars

pom.xml

@@ -390,13 +390,6 @@
 			<scope>test</scope>
 		</dependency>
 
-		<dependency>
-			<groupId>org.easytesting</groupId>
-			<artifactId>fest-assert-core</artifactId>
-			<version>${fest.assert.version}</version>
-			<scope>test</scope>
-		</dependency>
-		
 		<dependency>
 			<groupId>org.hamcrest</groupId>
 			<artifactId>hamcrest-library</artifactId>
@@ -447,13 +440,6 @@
 			<scope>test</scope>
 		</dependency>
 
-		<dependency>
-			<groupId>org.testng</groupId>
-			<artifactId>testng</artifactId>
-			<version>${testng.version}</version>
-			<scope>test</scope>
-		</dependency>
-		
 		<dependency>
 			<groupId>org.togglz</groupId>
 			<artifactId>togglz-testing</artifactId>
@@ -503,7 +489,6 @@
 		<error-prone-javac.version>9+181-r4173-1</error-prone-javac.version>
 		<error-prone.version>2.3.3</error-prone.version>
 		<failsafe.plugin.version>2.22.0</failsafe.plugin.version>
-		<fest.assert.version>2.0M8</fest.assert.version>
 		<gmavenplus.plugin.version>1.5</gmavenplus.plugin.version>
 
 		<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.5.20.RELEASE/spring-boot-dependencies/pom.xml) -->
@@ -592,7 +577,6 @@
 		<start-class>ru.mystamps.web.support.spring.boot.ApplicationBootstrap</start-class>
 
 		<surefire.plugin.version>2.22.0</surefire.plugin.version>
-		<testng.version>6.8.8</testng.version>
 		<thumbnailator.version>0.4.8</thumbnailator.version>
 
 		<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.5.20.RELEASE/spring-boot-dependencies/pom.xml) -->
@@ -868,9 +852,6 @@
 				<configuration>
 					<useFile>false</useFile>
 					<disableXmlReport>true</disableXmlReport>
-					<suiteXmlFiles>
-						<suiteXmlFile>${basedir}/src/test/config/testng.xml</suiteXmlFile>
-					</suiteXmlFiles>
 				</configuration>
 				<!-- Use default <execution> configuration from spring-boot-starter-parent -->
 			</plugin>
@@ -935,8 +916,6 @@
 				<configuration>
 					<skipTests>${skipUnitTests}</skipTests>
 					<disableXmlReport>${disableXmlReport}</disableXmlReport>
-					<!-- Run junit tests only (see #SUREFIRE-377) -->
-					<testNGArtifactName>none:none</testNGArtifactName>
 				</configuration>
 			</plugin>
 

src/main/config/checkstyle-suppressions.xml

@@ -5,9 +5,6 @@
 
 <suppressions>
 
-	<!-- These files will be removed during porting integration tests to Cucumber JVM (see #18) -->
-	<suppress checks="ImportOrder" files="ru.mystamps.web.tests" />
-	
 	<!-- false positives because these files contain SQL queries -->
 	<suppress checks="Translation" files="src[/\\]main[/\\]resources[/\\]sql" />