build: decommission of ErrorProne

Removal of ErrorProne also fixes compilation on JDK 17 (see #1350 and #1556)

The following issues won't be fixed:
Closes #999
Closes #1069
Closes #1235
Closes #1440

Part of #1669

Author: php-coder

pom.xml

@@ -572,8 +572,6 @@
 
 		<dockerfile.plugin.version>1.4.6</dockerfile.plugin.version>
 		<enforcer.plugin.version>3.0.0-M3</enforcer.plugin.version>
-		<error-prone-javac.version>9+181-r4173-1</error-prone-javac.version>
-		<error-prone.version>2.3.4</error-prone.version>
 		<frontend.plugin.version>1.7.6</frontend.plugin.version>
 		<gmavenplus.plugin.version>1.5</gmavenplus.plugin.version>
 
@@ -887,35 +885,7 @@
 					<failOnWarning>true</failOnWarning>
 					<compilerArgs>
 						<compilerArg>-Xlint:unchecked</compilerArg>
-						<!-- Required for ErrorProne -->
-						<!--
-							@todo #971 Document ErrorProne tool
-						-->
-						<compilerArg>-XDcompilePolicy=simple</compilerArg>
-						<!--
-							@todo #1170 ErrorProne: activate experimental checks
-						-->
-						<!--
-							The following checks have been disabled:
-							- MissingOverride: produce false positives with @Getter from Lombok
-							- MixedMutabilityReturnType: because I like to use Collections.empty*() methods
-							- UnnecessaryAnonymousClass: I prefer to have an explicit implementation in a constant
-							- PreferJavaTimeOverload: disabled because of false positives: https://github.com/google/error-prone/issues/1435
-						-->
-						<compilerArg>-Xplugin:ErrorProne -Xep:MissingOverride:OFF -Xep:MixedMutabilityReturnType:OFF -Xep:UnnecessaryAnonymousClass:OFF -Xep:PreferJavaTimeOverload:OFF</compilerArg>
 					</compilerArgs>
-					<annotationProcessorPaths>
-						<path>
-							<groupId>com.google.errorprone</groupId>
-							<artifactId>error_prone_core</artifactId>
-							<version>${error-prone.version}</version>
-						</path>
-						<path>
-							<groupId>org.projectlombok</groupId>
-							<artifactId>lombok</artifactId>
-							<version>${lombok.version}</version>
-						</path>
-					</annotationProcessorPaths>
 				</configuration>
 			</plugin>
 
@@ -1268,29 +1238,6 @@
 	</scm>
 
 	<profiles>
-		<profile>
-			<id>jdk8</id>
-			<activation>
-				<jdk>1.8</jdk>
-			</activation>
-			<build>
-				<plugins>
-					<plugin>
-						<groupId>org.apache.maven.plugins</groupId>
-						<artifactId>maven-compiler-plugin</artifactId>
-						<configuration>
-							<!-- Required for ErrorProne -->
-							<fork>true</fork>
-							<compilerArgs combine.children="append">
-								<compilerArg>
-									-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${error-prone-javac.version}/javac-${error-prone-javac.version}.jar
-								</compilerArg>
-							</compilerArgs>
-						</configuration>
-					</plugin>
-				</plugins>
-			</build>
-		</profile>
 		<profile>
 			<id>jdk11</id>
 			<activation>
@@ -1320,19 +1267,6 @@
 						<artifactId>maven-compiler-plugin</artifactId>
 						<configuration>
 							<release>17</release>
-							<fork>true</fork>
-							<compilerArgs combine.children="append">
-								<arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED</arg>
-								<arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</arg>
-								<arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED</arg>
-								<arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED</arg>
-								<arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED</arg>
-								<arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED</arg>
-								<arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED</arg>
-								<arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED</arg>
-								<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
-								<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
-							</compilerArgs>
 						</configuration>
 					</plugin>
 				</plugins>

src/main/java/ru/mystamps/web/feature/series/SeriesController.java

@@ -838,7 +838,7 @@ private static boolean isAllowedToAddingImages(SeriesDto series) {
 		return series.getImageIds().size() <= series.getQuantity();
 	}
 
-	// I like these parentheses and also ErrorProne suggests to have an explicit order
+	// I like these parentheses
 	@SuppressWarnings("PMD.UselessParentheses")
 	private static boolean isUserCanAddImagesToSeries(
 		Authentication authentication,