Fix additional type safety issues in sniffs and traits#50
Merged
dereuromark merged 1 commit intomasterfrom Mar 27, 2026
Merged
Conversation
- DocBlockReturnVoidSniff: Use === false check for findNext result - DocBlockReturnNullSniff: Add missing false check before loop - ArrayDeclarationSniff: Fix three !$var checks on findNext results - ImplicitCastSpacingSniff: Add false checks before arithmetic operations - UseStatementsTrait: Add false check before using semicolonIndex - NamespaceTrait: Add false check before array access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #49, fixing additional type safety issues discovered during a second code review.
Changes
DocBlockReturnVoidSniff.php!$endIndexcheck should be=== falseDocBlockReturnNullSniff.phpfalsecheck onfindNext()result before using in loopArrayDeclarationSniff.php!$nextTokenIndexchecks should be=== falseImplicitCastSpacingSniff.phpfalsechecks before arithmetic and array accessUseStatementsTrait.phpfalsecheck before using$semicolonIndex - 1NamespaceTrait.phpfalsecheck before array access$tokens[$next]Why This Matters
When
findNext()/findPrevious()returnsfalse(not found):!$vartreats bothfalseand0as falsy - but0is a valid token index$var - 1onfalsebecomes-1(sincefalse→0in arithmetic)$tokens[$var]onfalseaccesses$tokens[0](the<?phptoken)These bugs are theoretical (token 0 is always
<?php), but fixing them improves code correctness.