Skip to content

Document meaning of scale #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

Document meaning of scale #15

merged 1 commit into from
Dec 20, 2023

Conversation

@InvisibleSmiley
Copy link

@InvisibleSmiley InvisibleSmiley commented Dec 20, 2023 •
edited
Loading

This is for #13 which has not been resolved to my satisfaction.

I noticed that the $scale parameter of the divide signature has no default value.
Is that on purpose? Seems like a bug/oversight to me.

@dereuromark dereuromark merged commit 0e8ee11 into php-collective:master Dec 20, 2023
@InvisibleSmiley InvisibleSmiley deleted the fix-scaledoc branch December 20, 2023 11:43
@InvisibleSmiley
Copy link
Author

InvisibleSmiley commented Dec 20, 2023

I noticed that the $scale parameter of the divide signature has no default value. Is that on purpose? Seems like a bug/oversight to me.

Can you please comment on this part?
I'd like to know whether I should open an issue about it or not.

@dereuromark
Copy link
Contributor

dereuromark commented Dec 20, 2023

See #10
The main idea was that here it should be more user-invoked and not auto detected to avoid accidental loss of precision
But if this is not needed, we could think of removing this to make the API more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@InvisibleSmiley @dereuromark @jhatlak