Preserve attribute source order in output#113
Merged
dereuromark merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
Per djot spec and JS reference implementation, attributes should be
rendered in the order they appear in the source. For example,
`{#id .class}` should output `id="id" class="class"`.
Changes:
- Added `parseOrdered()` method to AttributeParser that uses single-pass
regex matching to preserve source order (same approach as applyToNode)
- Updated `parseAndMerge()` to use `parseOrdered()` instead of `parse()`
- Updated BlockParser list item attributes to use `parseOrdered()`
- Removed "id first" logic from HtmlRenderer that was overriding order
The old `parse()` method is kept for backwards compatibility but is no
longer used internally.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
============================================
+ Coverage 93.68% 93.75% +0.07%
- Complexity 2333 2340 +7
============================================
Files 79 79
Lines 6171 6198 +27
============================================
+ Hits 5781 5811 +30
+ Misses 390 387 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{#id .class}now correctly outputsid="id" class="class"instead ofclass="class" id="id"Root Cause
Two issues were causing attributes to be output in wrong order:
AttributeParser::parse()processed attributes in fixed order (class → id → key=value → boolean) instead of source orderHtmlRenderer::renderAttributes()explicitly movedidto the frontChanges
parseOrdered()method using single-pass regex (same approach asapplyToNode())parseAndMerge()and BlockParser to useparseOrdered()Test
All existing tests pass, including the official test suite which already expected source order.