Strip leading whitespace from paragraph content#115
Merged
dereuromark merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
The JS reference implementation strips all leading whitespace (spaces and tabs) from paragraph content, both on the first line and on continuation lines. The PHP implementation was only stripping up to 3 spaces from continuation lines, and not stripping the first line. Before: ` text` → `<p> text</p>` After: ` text` → `<p>text</p>` This fix uses ltrim() on both the first line and continuation lines to match the JS reference behavior. Added 2 tests covering leading whitespace stripping.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=========================================
Coverage 93.76% 93.76%
Complexity 2341 2341
=========================================
Files 79 79
Lines 6205 6205
=========================================
Hits 5818 5818
Misses 387 387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The JS reference strips all leading whitespace from paragraph text:
' text'→<p>text</p>Previously, PHP was preserving the whitespace:
' text'→<p> text</p>This fix applies
ltrim()to both the first line and continuation lines of paragraphs.