Skip to content

Fix extension render idempotence#119

Merged
dereuromark merged 1 commit intomasterfrom
fix/extension-render-idempotence
Mar 23, 2026
Merged

Fix extension render idempotence#119
dereuromark merged 1 commit intomasterfrom
fix/extension-render-idempotence

Conversation

@dereuromark
Copy link
Copy Markdown
Contributor

Summary

  • reset per-document extension state before rendering so TOC data does not leak across repeated conversions
  • make repeated rendering of the same parsed document idempotent for heading permalinks and class-adding extensions
  • add regression coverage for repeated convert() and render() calls and document the extension lifecycle behavior

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.83%. Comparing base (9163397) to head (2f1b679).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Extension/HeadingPermalinksExtension.php 92.30% 1 Missing ⚠️
src/Node/Node.php 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
- Coverage     93.84%   93.83%   -0.02%     
- Complexity     2349     2363      +14     
============================================
  Files            79       79              
  Lines          6224     6245      +21     
============================================
+ Hits           5841     5860      +19     
- Misses          383      385       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dereuromark dereuromark merged commit fa865fa into master Mar 23, 2026
4 of 6 checks passed
@dereuromark dereuromark deleted the fix/extension-render-idempotence branch March 23, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant